Bug 13492 - report modified dir when using iconv
Summary: report modified dir when using iconv
Status: RESOLVED FIXED
Alias: None
Product: rsync
Classification: Unclassified
Component: core (show other bugs)
Version: 3.1.3
Hardware: All All
: P5 normal (vote)
Target Milestone: ---
Assignee: Wayne Davison
QA Contact: Rsync QA Contact
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-06-28 11:09 UTC by jief
Modified: 2018-11-20 21:26 UTC (History)
1 user (show)

See Also:

Attachments
Terminal screenshot. (41.89 KB, image/png)
2018-06-28 11:09 UTC, jief 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description jief 2018-06-28 11:09:56 UTC 
Created attachment 14263 [details]
Terminal screenshot.

In a folder rsynctest_dst (for example)
  create a folder 'a'
  create a folder 'B'

Sync to a destination with --iconv options (I use rsync -a --iconv=UTF8-MAC,UTF-8 --out-format='%i  - %n  - %M' rsynctest_src/ rsynctest_dst/)

Touch folder 'B'
Dry run a sync with --iconv option (same as before with -n), folder 'a' is reported touched.
Dry run without iconv, folder 'B' is reported touched.
It looks like it syncs correctly because after a sync with --iconv, I have no dir reported touched anymore.

I compiled myself version 3.1.3 for my mac (high sierra).

I tried to fix. So far I'm wondering if it's because "need_unsorted_flist" is 1 when --iconv is used, but dir_list global var only keep sorted list. Not sure...
Comment 1 Wayne Davison 2018-11-20 21:26:31 UTC 
A fix has been committed to git. Thanks!