Fix building Samba with gcc 8.1. Patchset will follow.
Created attachment 14214 [details] patch for 4.8
Karolin, please add to 4.8. Thanks!
Patch does not apply on current v4-8-test. Re-assigning to Andreas.
I generated it from the v4-8-test tree: $ git w ## v4-8-test...origin/v4-8-test [ahead 14] However, I've just tested the attached patch from this bug and it applies fine here: git w ## v4-8-test...origin/v4-8-test [ahead 14] $ git co -b v4-8-test-gcc8 origin/v4-8-test Branch 'v4-8-test-gcc8' set up to track remote branch 'v4-8-test' from 'origin'. Switched to a new branch 'v4-8-test-gcc8' $ git am3 ~/Downloads/p/v4-8-test.patch1.txt Applying: s3-winbindd: use fill_domain_username_talloc() in winbind. Applying: s3-winbindd: remove unused fill_domain_username() Applying: s3-printing: fix format-truncation in print_queue_update() Applying: s4-torture: fix format-truncation warning in smb2 session tests. Applying: s3-utils: fix format-truncation in smbpasswd Applying: lib:util: Fix string check in mkdir_p() Applying: s4:torture: Use strlcpy() in gen_name() Applying: s3:lib: Use memcpy() in escape_ldap_string() Applying: s3:passdb: Fix size of ascii_p16 Applying: s3:winbind: Fix uninitialzed variable warning Applying: lib:util: Fix parameter aliasing in tfork test Applying: lib:util: Fix size types in debug.c Applying: s4:ntvfs: Fix string copy of share_name Applying: lib: Fix array size in audit_logging What error did you get exactly?
user@host:/data/git/samba/v4-8-test$ git am v4-8-test.patch1.txt Wende an: s3-winbindd: use fill_domain_username_talloc() in winbind. Wende an: s3-winbindd: remove unused fill_domain_username() error: Anwendung des Patches fehlgeschlagen: source3/winbindd/winbindd_proto.h:480 error: source3/winbindd/winbindd_proto.h: Patch konnte nicht angewendet werden Anwendung des Patches fehlgeschlagen bei 0002 s3-winbindd: remove unused fill_domain_username() But I pulled some other patches meanwhile, maybe it conflicts with the UPN patches. Waiting for Autobuild.
Ok, then I will wait for the autobuild and redo the patchset. And yes, I guess it conflicts with the UPN fixes.
Created attachment 14216 [details] patch for 4.8
Comment on attachment 14216 [details] patch for 4.8 LGTM but I found one more buildissue when building with heimdal
Created attachment 14233 [details] patch for 4.7
Created attachment 14234 [details] additional patch for heimdal We need to have this additional patch (for building heimdal) from master as well.
Karolin, the heimdal patch is needed for 4.7 and 4.8. The others according to their name.
(In reply to Andreas Schneider from comment #11) Pushed to autobuild-v4-[8,7]-test.
(In reply to Karolin Seeger from comment #12) Seems to break build on v4-7-test. [3243/4205] Compiling source3/winbindd/wb_getpwsid.c ../source3/winbindd/wb_getpwsid.c: In function ‘wb_getpwsid_queryuser_done’: ../source3/winbindd/wb_getpwsid.c:119:9: error: ‘output_username’ may be used uninitialized in this function [-Werror=maybe-uninitialized] strlcpy(pw->pw_name, output_username, sizeof(pw->pw_name)); ^ cc1: all warnings being treated as errors Waf: Leaving directory `/memdisk/kseeger/a47/b3212943/samba-o3/bin' Build failed: -> task failed (err #1): {task: cc wb_getpwsid.c -> wb_getpwsid_45.o} make: *** [all] Error 1 Re-assigning to Günther.
Created attachment 14244 [details] revised version of patch for 4.7
I think this revealed a bug. output_username should be set as pwd->pw_name is filled with it. So the else if branch should be merged with the if (NTSTATUS_IS_OK(status))?
Created attachment 14248 [details] additional patch for 4.8
Created attachment 14249 [details] full patchset for 4.7
The additional patch of bug #12851 needs to be applied first.
Created attachment 14250 [details] full patchset for 4.7
Comment on attachment 14248 [details] additional patch for 4.8 LGTM
Comment on attachment 14250 [details] full patchset for 4.7 LGTM
Karolin, please add to 4.7 and 4.8. Thanks!
Pushed additional patch to autobuild-v4-8-test.
(In reply to Andreas Schneider from comment #17) Pushed to autobuild-v4-7-test.
Pushed to both branches. Closing out bug report. Thanks!