Bug 13269 - RODC may skip objects during replication due to naming conflicts
RODC may skip objects during replication due to naming conflicts
Status: NEW
Product: Samba 4.1 and newer
Classification: Unclassified
Component: AD: LDB/DSDB/SAMDB
unspecified
All All
: P5 normal
: ---
Assigned To: Andrew Bartlett
Samba QA Contact
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2018-02-14 03:18 UTC by Garming Sam
Modified: 2018-02-14 04:20 UTC (History)
0 users

See Also:


Attachments
Patch against returning LDB_SUCCESS upon failure (1.51 KB, patch)
2018-02-14 04:20 UTC, Douglas Bagnall
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Garming Sam 2018-02-14 03:18:52 UTC
On a normal DC, naming conflicts result in conflict records, but on an RODC, the conflict records cannot be created.

This was meant to cause replication to fail, however, because an error code was not being set, it was possible for RODCs to have fewer objects or updates than the highwatermark or the uptodateness vector would indicate.


This lead to errors like:
Failed to apply records: replmd_replicated_apply_add: error during DRS repl ADD: No objectClass found in replPropertyMetaData

Which would occur because an object had been skipped.

Original thread on samba-technical:
https://lists.samba.org/archive/samba-technical/2018-January/124938.html
Comment 1 Douglas Bagnall 2018-02-14 04:20:13 UTC
Created attachment 13960 [details]
Patch against returning LDB_SUCCESS upon failure

There are a number of places where we have `goto failed` without the return code being set. 

We could fix them all individually, or we could do something like this, catching potential future cases, or we could do both.