Bug 13233 - Erroneously calling set_routing_domain() with domain=NULL
Summary: Erroneously calling set_routing_domain() with domain=NULL
Status: RESOLVED FIXED
Alias: None
Product: Samba 4.1 and newer
Classification: Unclassified
Component: Winbind (show other bugs)
Version: unspecified
Hardware: All All
: P5 normal (vote)
Target Milestone: ---
Assignee: Ralph Böhme
QA Contact: Samba QA Contact
URL:
Keywords:
Depends on: 13231
Blocks:
  Show dependency tree / graph
 
Reported: 2018-01-18 17:21 UTC by Ralph Böhme
Modified: 2018-02-12 09:43 UTC (History)
0 users

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ralph Böhme 2018-01-18 17:21:41 UTC 
add_trusted_domain() can return domain=NULL and we don't check this before calling set_routing_domain(NULL, ...) which will crash.
Comment 1 Ralph Böhme 2018-02-10 08:08:24 UTC 
Patched in master. Backport for 4.8 attached to bug #13231.
Comment 2 Ralph Böhme 2018-02-12 09:43:41 UTC 
Pushed to both 4-8-test, closing out bug report.