Bug 13224 - New file handling causes compile issues for NonStop port.
New file handling causes compile issues for NonStop port.
Status: RESOLVED WORKSFORME
Product: rsync
Classification: Unclassified
Component: core
3.1.3
Other Other
: P5 normal
: ---
Assigned To: Wayne Davison
Rsync QA Contact
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2018-01-15 18:47 UTC by Randall S. Becker
Modified: 2018-01-15 22:58 UTC (History)
0 users

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Randall S. Becker 2018-01-15 18:47:43 UTC
On the HPE NonStop NSX and NSE hardware, L-series and J-series operating systems, respectively, the following compiler errors have been introduced since 3.1.2. The sys/file.h components are not available on this platform, nor is there a suitable replacement. The time-related items can be handled by my team, but makedev, major, and minor, functions/defines, are not available on this platform.

cc -c99 -I. -I. -I./zlib -I./popt -g -DHAVE_CONFIG_H  -c flist.c -o flist.o
                        if ((uint32)major(rdev) == rdev_major)
                                    ^
"/home/git/rsync/flist.c", line 436: error(114): identifier "major" is undefined
                        if (protocol_version < 30 && (uint32)minor(rdev) <= 0xFFu)
                                                             ^ "/home/git/rsync/flist.c", line 440: error(114): identifier "minor" is
          undefined
                        rdev = MAKEDEV(major(rdev), 0);
                               ^
"/home/git/rsync/flist.c", line 449: error(114): identifier "makedev" is undefined
                        rdev = MAKEDEV(major(rdev), 0);
                               ^
"/home/git/rsync/flist.c", line 449: error(114): identifier "major" is undefined
                rdev = MAKEDEV(0, 0);
                       ^
"/home/git/rsync/flist.c", line 455: error(114): identifier "makedev" is undefined
                                write_varint30(f, major(rdev));
                                                  ^ "/home/git/rsync/flist.c", line 599: error(114): identifier "major" is undefined
                                write_varint(f, minor(rdev));
                                                ^ "/home/git/rsync/flist.c", line 601: error(114): identifier "minor" is undefined
                                write_byte(f, minor(rdev));
                                              ^ "/home/git/rsync/flist.c", line 603: error(114): identifier "minor" is undefined
                                write_int(f, minor(rdev));
                                             ^ "/home/git/rsync/flist.c", line 605: error(114): identifier "minor" is undefined
                                rdev = MAKEDEV(DEV_MAJOR(devp), DEV_MINOR(devp));
                                       ^ "/home/git/rsync/flist.c", line 770: error(114): identifier "makedev" is undefined
                        rdev = MAKEDEV(rdev_major, rdev_minor);
                               ^
"/home/git/rsync/flist.c", line 845: error(114): identifier "makedev" is undefined
                rdev = MAKEDEV(0, 0);
                       ^
"/home/git/rsync/flist.c", line 851: error(114): identifier "makedev" is undefined
                DEV_MAJOR(devp) = major(rdev);
                                  ^
"/home/git/rsync/flist.c", line 1008: error(114): identifier "major" is undefined
                DEV_MINOR(devp) = minor(rdev);
                                  ^
"/home/git/rsync/flist.c", line 1009: error(114): identifier "minor" is undefined

cc -c99 -I. -I. -I./zlib -I./popt -g -DHAVE_CONFIG_H  -c generator.c -o generator.o
                        if (sxp->st.st_rdev != MAKEDEV(DEV_MAJOR(devp), DEV_MINOR(devp)))
                                               ^ "/home/git/rsync/generator.c", line 1049: error(114): identifier "makedev" is undefined
                                DEV_MAJOR(devp) = major(real_sx.st.st_dev);
                                                  ^ "/home/git/rsync/generator.c", line 1476: error(114): identifier "major" is undefined
                                DEV_MINOR(devp) = minor(real_sx.st.st_dev);
                                                  ^ "/home/git/rsync/generator.c", line 1477: error(114): identifier "minor" is undefined
                if (atomic_create(file, fname, sl, NULL, MAKEDEV(0, 0), &sx, statret == 0 ? DEL_FOR_SYMLINK : 0)) {
                                                         ^ "/home/git/rsync/generator.c", line 1558: error(114): identifier "makedev" is undefined
                        rdev = MAKEDEV(DEV_MAJOR(devp), DEV_MINOR(devp));
                               ^
"/home/git/rsync/generator.c", line 1588: error(114): identifier "makedev" is undefined
                                (long)major(rdev), (long)minor(rdev));
                                      ^
"/home/git/rsync/generator.c", line 1637: error(114): identifier "major" is undefined
                                (long)major(rdev), (long)minor(rdev));
                                                         ^ "/home/git/rsync/generator.c", line 1637: error(114): identifier "minor" is undefined
                                                dirdev = MAKEDEV(DEV_MAJOR(devp), DEV_MINOR(devp));
                                                         ^ "/home/git/rsync/generator.c", line 2252: error(114): identifier "makedev" is undefined
                                                dirdev = MAKEDEV(0, 0);
                                                         ^ "/home/git/rsync/generator.c", line 2254: error(114): identifier "makedev" is undefined

cc -c99 -I. -I. -I./zlib -I./popt -g -DHAVE_CONFIG_H  -c syscall.c -o syscall.o
        return utime(fname, t);
                            ^
"/home/git/rsync/syscall.c", line 448: error(252): argument of type "time_t *" is incompatible with parameter of type "const struct utimbuf *"

cc -c99 -I. -I. -I./zlib -I./popt -g -DHAVE_CONFIG_H  -c hlink.c -o hlink.o
        if (atomic_create(file, fname, NULL, oldname, MAKEDEV(0, 0), sxp, statret == 0 ? DEL_FOR_FILE : 0)) {
                                                      ^ "/home/git/rsync/hlink.c", line 234: error(114): identifier "makedev" is undefined

cc -c99 -I. -I. -I./zlib -I./popt -g -DHAVE_CONFIG_H  -c lib/compat.c -o lib/compat.o
        return gettimeofday(tv);
                              ^
"/home/git/rsync/lib/compat.c", line 154: error(250): too few arguments in function call
Comment 1 Randall S. Becker 2018-01-15 22:58:33 UTC
The reported (me) reapplied the platform specifics manually and resolved the compile issues.