Bug 13198 - installed man-pages include build paths
Summary: installed man-pages include build paths
Alias: None
Product: Samba 4.1 and newer
Classification: Unclassified
Component: Documentation (show other bugs)
Version: 4.7.3
Hardware: All All
: P5 normal (vote)
Target Milestone: ---
Assignee: Jo Sutton
QA Contact: Samba Documentation QA Contact~
Depends on:
Reported: 2017-12-22 19:00 UTC by Andrew Bartlett
Modified: 2024-06-09 20:31 UTC (History)
1 user (show)

See Also:


Note You need to log in before you can comment on or make changes to this bug.
Description Andrew Bartlett 2017-12-22 19:00:40 UTC
The installed smb.conf includes the build path in the defaults for dns update command.

The final install path is not used as when the manpage is generated the is_install flag is set to false and so the internal path is used to satisfy the 'docs' test (checking default values). 

XML entities are used to ensure that these paths in the docs match the installed paths on the system. 

However, the entity generation in dynconfig/wscript depends on is_install but this is not marked as a dependency so it is not re-run for the 'final' manpages to be installed. 

Either that flag needs somehow to become a dependency or these parameters be skipped in the test and the is_install flag not respected in this case.

Found by the debian reproducible builds effort:

Comment 1 Mathieu Parent 2018-10-30 20:45:27 UTC
For cross-reference, Debian bug is https://bugs.debian.org/912340
Comment 2 Michael Tokarev 2022-12-06 07:01:21 UTC
It looks like this has been fixed quite some time ago.  The patch proposed in debian still applies but the thing works fine now without, the path for SCRIPTSBINDIR is correctly propagated to the manpages, and the manpages are being correctly rebuilt during build procedure.  The bug can be closed now.
Comment 3 Douglas Bagnall 2024-06-07 01:11:05 UTC
Closing based on comment #2.

I hope the build is now deterministic with the patches linked to bug 13213 (or https://gitlab.com/samba-team/samba/-/merge_requests/3652), though my tests for that did not include building from a different directory.