Bug 13181 - Fail to copy file with empty FinderInfo from Windows client to Samba share with fruit
Fail to copy file with empty FinderInfo from Windows client to Samba share wi...
Status: ASSIGNED
Product: Samba 4.1 and newer
Classification: Unclassified
Component: VFS Modules
unspecified
All All
: P5 normal
: ---
Assigned To: Ralph Böhme
Samba QA Contact
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2017-12-07 16:55 UTC by Ralph Böhme
Modified: 2017-12-07 19:08 UTC (History)
1 user (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Ralph Böhme 2017-12-07 16:55:32 UTC
Alas, a Mac client wouldn't do this, but what can you do?

Currently when the client sends a AFP_AfpInfo stream where the contained FinderInfo blob is all 0, vfs_fruit will somewhat hackish delete the stream from the backing store. This causes subsequent operations on the same filehandle to fail for certain operations, also depending on the setting of fruit:metadata.

The correct implementation of the stream removal would be setting delete-on-close on the filehandle, while at the same time checking in delete-on-close is set in the stream-listing function.

Have patch, need bugnumber.