Bug 13144 - samba-4.7.2/source4/heimdal/lib/hcrypto/libtommath/bn_mp_div.c:45: strange expression ?
samba-4.7.2/source4/heimdal/lib/hcrypto/libtommath/bn_mp_div.c:45: strange ex...
Status: NEW
Product: Samba 4.1 and newer
Classification: Unclassified
Component: Other
4.7.2
All All
: P5 normal
: ---
Assigned To: Andrew Bartlett
Samba QA Contact
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2017-11-15 14:24 UTC by David Binderman
Modified: 2017-11-15 14:24 UTC (History)
0 users

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description David Binderman 2017-11-15 14:24:57 UTC
samba-4.7.2/source4/heimdal/lib/hcrypto/libtommath/bn_mp_div.c:45]: (style) Suspicious condition (assignment + comparison); Clarify expression with parentheses.

Source code is

  if ((res = mp_init_multi(&ta, &tb, &tq, &q, NULL) != MP_OKAY)) {

Maybe better code:

  if ((res = mp_init_multi(&ta, &tb, &tq, &q, NULL)) != MP_OKAY) {