The strerror_r patch (making Samba provide and use the XSI strerror_r not the GNU one) broke the tests the manually include replace.c on systems that use libbsd to get strlcpy. This is the diff of config.log (but not shown on-screen) with the fix: @@ -620514,11 +617230,6 @@ <== [1/2] Compiling test.c -In file included from ../test.c:1188:0: -/data/samba/git/samba/tests/summary.c: In function ‘main’: -/data/samba/git/samba/tests/summary.c:12:2: warning: #warning "WARNING: No automated network interface determination" [-Wcpp] - #warning "WARNING: No automated network interface determination" - ^~~~~~~ This is the config.h diff: --- bin/default/include/config.h 2017-10-14 22:30:00.363872416 +1300 +++ /tmp/config.h 2017-10-14 22:28:53.533692123 +1300 @@ -428,10 +428,7 @@ /* #undef HAVE_SOCK_SIN_LEN */ #define HAVE_UNIXSOCKET 1 #define HAVE_SECURE_MKSTEMP 1 -/* #undef HAVE_IFACE_GETIFADDRS */ -/* #undef HAVE_IFACE_AIX */ -/* #undef HAVE_IFACE_IFCONF */ -/* #undef HAVE_IFACE_IFREQ */ +#define HAVE_IFACE_GETIFADDRS 1 #define HAVE_DECL_GETPWENT_R 1 /* #undef SOLARIS_GETPWENT_R */ #define HAVE_DECL_GETGRENT_R 1
Created attachment 13687 [details] proposed patch for master
Created attachment 13734 [details] patch for 4.7 cherry-picked from master This should be merged for 4.7.next
Pushed to autobuild-v4-7-test.
(In reply to Karolin Seeger from comment #3) Pushed to v4-7-test. Closing out bug report. Thanks!