Bug 12985 - smbtorture --unclist ineffective for smb2 TCs
Summary: smbtorture --unclist ineffective for smb2 TCs
Status: RESOLVED FIXED
Alias: None
Product: Samba 4.1 and newer
Classification: Unclassified
Component: smbtorture (show other bugs)
Version: unspecified
Hardware: All Linux
: P5 normal (vote)
Target Milestone: ---
Assignee: Andrew Bartlett
QA Contact: Samba QA Contact
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-08-24 08:56 UTC by Peter Somogyi
Modified: 2017-08-31 12:38 UTC (History)
0 users

See Also:

Attachments
Minimalist tested patch that enables clustered tests. (1.90 KB, patch)
2017-08-24 08:56 UTC, Peter Somogyi 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Peter Somogyi 2017-08-24 08:56:09 UTC 
Created attachment 13497 [details]
Minimalist tested patch that enables clustered tests.

smbtorture from with smb2.* test with the recent samba master still communicating on one IP:

bin/smbtorture //<ip>/test --unclist=unclist.txt --option=torture:nprocs=4 -UAdministrator%<password> -W <domain> smb2.oplock

cat unclist
<ip1>
<ip2>
<ip3>
<ip4>

Doing tcpdump on each server nodes showing traffic only on <ip>.
When I compile the attached patch, it gets working on all IPs.

As you see it by code, the documented --unclist option is supported only with the SMB1 tests (that are today deprecated).
Comment 1 Peter Somogyi 2017-08-31 12:38:49 UTC 
Final polished patch went in as f0b85c1da2617f1b4d6f17a2cdab60943aca35e6, verified and closing.