Bug 12961 - Solaris Studio C build issues
Solaris Studio C build issues
Status: NEW
Product: Samba 4.1 and newer
Classification: Unclassified
Component: Build
4.7.0rc3
All All
: P5 normal
: ---
Assigned To: Samba QA Contact
Samba QA Contact
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2017-08-12 23:06 UTC by Jura Sasek
Modified: 2019-01-06 22:15 UTC (History)
2 users (show)

See Also:


Attachments
solarisstudio 12.3 do not support no-format-zero-length (934 bytes, patch)
2017-08-12 23:06 UTC, Jura Sasek
no flags Details
studio do not allow return value from the void func() (974 bytes, patch)
2017-08-12 23:08 UTC, Jura Sasek
no flags Details
sun4v (sparc) is not detected as lp64 (471 bytes, patch)
2017-08-12 23:08 UTC, Jura Sasek
no flags Details
param/loadparm.c need -Ipath to find krb5 headers (503 bytes, patch)
2017-08-12 23:11 UTC, Jura Sasek
no flags Details
git patch (3.31 KB, patch)
2017-08-15 18:03 UTC, Jura Sasek
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Jura Sasek 2017-08-12 23:06:19 UTC
Created attachment 13461 [details]
solarisstudio 12.3 do not support no-format-zero-length

Solaris studio build is failing on several places. Could it be possible to review and merge attached patches please.
Thank you,
Jiri
Comment 1 Jura Sasek 2017-08-12 23:08:04 UTC
Created attachment 13462 [details]
studio do not allow return value from the void func()
Comment 2 Jura Sasek 2017-08-12 23:08:48 UTC
Created attachment 13463 [details]
sun4v (sparc) is not detected as lp64
Comment 3 Jura Sasek 2017-08-12 23:11:28 UTC
Created attachment 13464 [details]
param/loadparm.c need -Ipath to find krb5 headers
Comment 4 Volker Lendecke 2017-08-14 09:33:43 UTC
Jiri, can you format them as git-format patches and send them to samba-technical? They all look good. If you're at SDC in September, ping me and I'll show you how to do that.
Comment 5 Jura Sasek 2017-08-15 18:03:25 UTC
Created attachment 13474 [details]
git patch

Here is it. Collects all 4 previous patches.
Comment 6 Douglas Bagnall 2019-01-03 04:03:41 UTC
These ones are already in:

-	return test_ldb_modify_during_search(state, true, false);
+	test_ldb_modify_during_search(state, true, false);


This one needs to go upstream first (but won't apply any more):

--- a/third_party/cmocka/cmocka.h
+++ b/third_party/cmocka/cmocka.h
Comment 7 Douglas Bagnall 2019-01-03 04:11:30 UTC
This will break if 'HAVE_WNO_FORMAT_ZERO_LENGTH' is not set but 'HAVE_WNO_FORMAT_TRUNCATION' is (because += on an unset variable).

-    replace_test_cflags="-Wno-format-zero-length"
+    if bld.CONFIG_SET('HAVE_WNO_FORMAT_ZERO_LENGTH'):
+        replace_test_cflags="-Wno-format-zero-length"
     if bld.CONFIG_SET('HAVE_WNO_FORMAT_TRUNCATION'):
         replace_test_cflags += " -Wno-format-truncation"
     bld.SAMBA_SUBSYSTEM('replace-test',


Also it doesn't apply easily as things have shifted in that file.
Comment 8 Björn Jacke 2019-01-06 21:56:44 UTC
the hook adding the krb5 dependency in source3/wscript_build is a duplicate of bug 10047 - the tests made in waf for ldap library detection need a generic overhaul.