The Samba-Bugzilla – Bug 12961
Solaris Studio C build issues
Last modified: 2019-01-06 22:15:41 UTC
Created attachment 13461 [details]
solarisstudio 12.3 do not support no-format-zero-length
Solaris studio build is failing on several places. Could it be possible to review and merge attached patches please.
Created attachment 13462 [details]
studio do not allow return value from the void func()
Created attachment 13463 [details]
sun4v (sparc) is not detected as lp64
Created attachment 13464 [details]
param/loadparm.c need -Ipath to find krb5 headers
Jiri, can you format them as git-format patches and send them to samba-technical? They all look good. If you're at SDC in September, ping me and I'll show you how to do that.
Created attachment 13474 [details]
Here is it. Collects all 4 previous patches.
These ones are already in:
- return test_ldb_modify_during_search(state, true, false);
+ test_ldb_modify_during_search(state, true, false);
This one needs to go upstream first (but won't apply any more):
This will break if 'HAVE_WNO_FORMAT_ZERO_LENGTH' is not set but 'HAVE_WNO_FORMAT_TRUNCATION' is (because += on an unset variable).
+ if bld.CONFIG_SET('HAVE_WNO_FORMAT_ZERO_LENGTH'):
replace_test_cflags += " -Wno-format-truncation"
Also it doesn't apply easily as things have shifted in that file.
the hook adding the krb5 dependency in source3/wscript_build is a duplicate of bug 10047 - the tests made in waf for ldap library detection need a generic overhaul.