Bug 12916 - when rsync fails to chown, it gives up and does not set timestamp
Summary: when rsync fails to chown, it gives up and does not set timestamp
Status: NEW
Alias: None
Product: rsync
Classification: Unclassified
Component: core (show other bugs)
Version: 3.1.3
Hardware: All All
: P5 minor (vote)
Target Milestone: ---
Assignee: Wayne Davison
QA Contact: Rsync QA Contact
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-07-18 22:47 UTC by Ian Kelling
Modified: 2017-07-19 02:29 UTC (History)
0 users

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ian Kelling 2017-07-18 22:47:41 UTC 
If I do

rsync -ot VFAT_FS_MOUNT

It outputs

rsync: chown "SOME_PATH" failed: Operation not permitted (1)

And it's timestamp is the current time, not the source time as specified
by -t. Rsync should not give up on setting the time just because it
couldn't set the owner. rsync -t works fine.

I tested on git master from today, ce854cf021cb7207ee504c6badf97b4ffbb2021a
Comment 1 Kevin Korb 2017-07-19 00:31:09 UTC 
If you mount your FAT filesystems with the quiet option the FAT driver will just ignore the operations it can't do instead of throwing fatal errors at you.  This will resolve problems in many tools including rsync.
Comment 2 Ian Kelling 2017-07-19 02:29:58 UTC 
Great tip. If we can solve it that would be
good too.