Bug 12903 - File change notification for renames not working
File change notification for renames not working
Status: ASSIGNED
Product: Samba 4.1 and newer
Classification: Unclassified
Component: File services
unspecified
All All
: P5 normal
: ---
Assigned To: Karolin Seeger
Samba QA Contact
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2017-07-13 10:13 UTC by Ralph Böhme
Modified: 2017-09-27 10:39 UTC (History)
3 users (show)

See Also:


Attachments
Patch for 4.6 backported from master (52.11 KB, patch)
2017-09-27 10:18 UTC, Ralph Böhme
slow: review? (jra)
vl: review+
Details
Patch for 4.7 backported from master (52.13 KB, patch)
2017-09-27 10:19 UTC, Ralph Böhme
slow: review? (jra)
vl: review+
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Ralph Böhme 2017-07-13 10:13:05 UTC
Versions up to commit 939576d968d1e0159456baf6dd1e3c454b98995a had a bug in the messaging subsystem that resulted in rename change notifcation to get stuck and lost.

The patches in master 5eccc2fd0072409f166c63e6876266f926411423~10..5eccc2fd0072409f166c63e6876266f926411423 fix the problem by removing messaging_handler_send which was causing the problem.
Comment 1 Ralph Böhme 2017-07-13 14:33:17 UTC
Some more details:

this bug only affects configurations with "kernel change notify = yes" and builds with effective inotify support built in (FAM probably as well, not tested).

It's caused by the use of firing two immediate tevents for the "old-name" and "new-name" events due to a bug in messaging_handler_send() (more precisely: in the machinery it uses).

Commits b6d6f67..5eccc2f already fixed this in master but the bug still affects all released versions up to 4.7rc1.
Comment 2 Ralph Böhme 2017-09-27 10:18:32 UTC
Created attachment 13635 [details]
Patch for 4.6 backported from master
Comment 3 Ralph Böhme 2017-09-27 10:19:19 UTC
Created attachment 13636 [details]
Patch for 4.7 backported from master
Comment 4 Ralph Böhme 2017-09-27 10:39:16 UTC
Reassigning to Karolin for inclusion in 4.6 and 4.7.