The Samba-Bugzilla – Bug 12903
File change notification for renames not working
Last modified: 2017-09-27 10:39:16 UTC
Versions up to commit 939576d968d1e0159456baf6dd1e3c454b98995a had a bug in the messaging subsystem that resulted in rename change notifcation to get stuck and lost.
The patches in master 5eccc2fd0072409f166c63e6876266f926411423~10..5eccc2fd0072409f166c63e6876266f926411423 fix the problem by removing messaging_handler_send which was causing the problem.
Some more details:
this bug only affects configurations with "kernel change notify = yes" and builds with effective inotify support built in (FAM probably as well, not tested).
It's caused by the use of firing two immediate tevents for the "old-name" and "new-name" events due to a bug in messaging_handler_send() (more precisely: in the machinery it uses).
Commits b6d6f67..5eccc2f already fixed this in master but the bug still affects all released versions up to 4.7rc1.
Created attachment 13635 [details]
Patch for 4.6 backported from master
Created attachment 13636 [details]
Patch for 4.7 backported from master
Reassigning to Karolin for inclusion in 4.6 and 4.7.