Bug 12838 - [PATCH] Log sent/received bytes even in case of error
Summary: [PATCH] Log sent/received bytes even in case of error
Alias: None
Product: rsync
Classification: Unclassified
Component: core (show other bugs)
Version: 3.1.3
Hardware: All All
: P5 normal (vote)
Target Milestone: ---
Assignee: Wayne Davison
QA Contact: Rsync QA Contact
Depends on:
Reported: 2017-06-13 13:56 UTC by Ben RUBSON
Modified: 2020-05-26 17:57 UTC (History)
0 users

See Also:

rsync_log_daemon (645 bytes, patch)
2017-06-13 13:56 UTC, Ben RUBSON
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Ben RUBSON 2017-06-13 13:56:16 UTC
Created attachment 13271 [details]


This patch allows the daemon to log data sent/received even in case of error, which can be interesting to have when the transfer has been interrupted by the client.

Thank you !

Comment 1 Ben RUBSON 2017-06-13 14:52:23 UTC
Mmmmh unfortunately numbers are not correct.

# Sender side (which interrupts the transfer receiving SIGUSR2) :
Total file size: 16­.85G bytes 
Total transferred file size: 183­.38M bytes 
Literal data: 182­.32M bytes 

# Receiver side : 
rsyncd: rsync: connection unexpectedly closed (202529 bytes received so far) [generator]
rsyncd: sent 24749 bytes  received 202529 bytes  total size 16845198594

Perhaps related to bug #10738 where stats are also not correctly calculated.
Comment 2 Ben RUBSON 2020-05-26 17:57:17 UTC
Patch moved : https://github.com/WayneD/rsync/pull/5