Created attachment 13188 [details] level 10 debug log Problem description: If you run an smbcacls command without specifying the password in the -U parameter, the command fails and prints: > cli_full_connection failed! (NT_STATUS_LOGON_FAILURE) instead of asking for the password such as other tool do (e. g. "net" or "samba-tool"). Steps to reproduce: 1. Run: # smbcacls //M1/DemoShare01 -Uadministrator / cli_full_connection failed! (NT_STATUS_LOGON_FAILURE) Further details: * The command works if you add the password to the -U parameter. For example: # smbcacls //M1/DemoShare01 -Uadministrator%password / But this should not be the recommended way. * Connections also work if you have a valid Kerberos ticket and pass the -k option to the command
Created attachment 13189 [details] proposed patch Does this patch help?
Thanks, Christian. The patch applies without any problems to 4.6.3 and fixes the problem.
(In reply to Marc Muehlfeld from comment #2) Thanks for the feedback. Will roll the patch over samba-technical for review and push.
Created attachment 13207 [details] patch for 4.6.x/4.5.x with cherry-pick information Patch applies to 4-6-test and 4-5-test
Karolin, please add the patch to the relevant branches. Thanks!
(In reply to Andreas Schneider from comment #5) Pushed to autobuild-v4-{6,5}-test.
(In reply to Karolin Seeger from comment #6) v4-5-test: [3230/4067] Compiling source3/utils/smbcacls.c ../source3/utils/smbcacls.c: In function ‘main’: ../source3/utils/smbcacls.c:922:2: error: implicit declaration of function ‘popt_common_credentials_post’ [-Werror=implicit-function-declaration] popt_common_credentials_post(); ^ cc1: all warnings being treated as errors
I've discussed it with Andreas: putting the fix into 4.5 would need a back port of a lot of other changes to make it work. We consider this as too risky. So let's restrict this fix to 4.6.x, the auto build for that should work.
(In reply to Christian Ambach from comment #8) Ok, thanks! Pushed to v4-6-test. Closing out bug report. Thanks!