Created attachment 13058 [details]
Patch for URL Escaping Path Qualifier

I originally submitted this patch to the samba-technical mailing list but received no response so I am submitting it along with this bug report.

Previous discussion can be found at:

https://lists.samba.org/archive/samba-technical/2016-August/115712.html

Basically, when running a search from within a nested directory and that directory’s path contains spaces, the generated sparql query will always return and empty result set. The problem is that the patch needs to be escaped and it is not.

For example, when searching for a file that starts with "Deposit" in given the path "/srv/smb/Groups/My Folder/Deposits/2011/" the query currently generated is:

19 Aug 2016, 02:24:15: Tracker: ---- [21|smbd|7822] query: SELECT ?url WHERE { ?obj fts:match 'Deposit*' . ?obj nie:url ?url . FILTER(tracker:uri-is-descendant('file:///srv/smb/Groups/My Folder/Deposits/2011/', ?url)) }
19 Aug 2016, 02:24:15: Tracker: ---> [21|smbd|7822] Success, no error given

...this query will always return an empty result even if there are files located within the search directory that start with the word "Deposit". The correct query should look like:

SELECT ?url WHERE { ?obj fts:match 'Deposit*' . ?obj nie:url ?url . FILTER(tracker:uri-is-descendant('file:///srv/smb/Groups/My%20Folder/Deposits/2011/', ?url)) }

The attached patch modifies “map_spotlight_to_sparql_query” in “samba/source3/rpc_server/mdssvc/sparql_parser.c” to url encode the directory path when generating the “FILTER” statement.