Bug 12596 - ldbedit and --reveal reactivates dead links
Summary: ldbedit and --reveal reactivates dead links
Alias: None
Product: Samba 4.1 and newer
Classification: Unclassified
Component: AD: LDB/DSDB/SAMDB (show other bugs)
Version: 4.5.0
Hardware: All All
: P5 normal (vote)
Target Milestone: ---
Assignee: Andrew Bartlett
QA Contact: Samba QA Contact
Depends on:
Reported: 2017-02-21 21:12 UTC by Garming Sam
Modified: 2019-06-12 15:01 UTC (History)
1 user (show)

See Also:

patch for 4.6 (1.95 KB, patch)
2017-02-28 01:58 UTC, Garming Sam
abartlet: review+
patch for 4.5 (1.95 KB, patch)
2017-02-28 02:25 UTC, Garming Sam
abartlet: review-

Note You need to log in before you can comment on or make changes to this bug.
Description Garming Sam 2017-02-21 21:12:53 UTC
Reveal will always show deleted links in the database, and ldbedit will always re-add them since they are in the search output. This is almost certainly not what you want.
Comment 1 Garming Sam 2017-02-28 01:58:25 UTC
Created attachment 12989 [details]
patch for 4.6
Comment 2 Garming Sam 2017-02-28 02:25:25 UTC
Created attachment 12991 [details]
patch for 4.5
Comment 3 Andrew Bartlett 2017-02-28 08:21:45 UTC
Comment on attachment 12991 [details]
patch for 4.5

Sadly we can't trivially backport to 4.5 as that means backporting all of the ldb changes made since 4.5 was forked. 

We also need to make an LDB release (metze generally does that) between now and the 4.6 release, and backport that.
Comment 4 Andrew Bartlett 2017-02-28 08:24:11 UTC
We also need a2daa664ccd284b8894e67ed307a0bd761eb82db backported (similar patch for show-binary) before we can backport the release cut.
Comment 5 Andrew Bartlett 2019-06-12 15:01:32 UTC
Fixed by bed19f3744a4193bed1ea99debfb6263feb78b6c in Samba 4.7.  No backports were done but these versions are no longer supports.