Bug 12590 - PIDL should consider passing structure by reference and not by value
Summary: PIDL should consider passing structure by reference and not by value
Status: NEW
Alias: None
Product: Samba 4.1 and newer
Classification: Unclassified
Component: Other (show other bugs)
Version: 4.6.0rc3
Hardware: All All
: P5 normal (vote)
Target Milestone: ---
Assignee: Stefan Metzmacher
QA Contact: Samba QA Contact
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-02-16 15:48 UTC by Andreas Schneider
Modified: 2017-02-16 20:17 UTC (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andreas Schneider 2017-02-16 15:48:27 UTC 
One of our tools reported that we copy a rather big structure around by value instead of pass by reference.

This could impact the performance. You might want to look this. The biggest structure passed by value is:

bin/default/librpc/gen_ndr/ndr_nbt_c.c:180: pass_by_value: Passing parameter 
_packet of type "struct netlogon_samlogon_response" (size 160 bytes) by value.