Bug 12590 - PIDL should consider passing structure by reference and not by value
PIDL should consider passing structure by reference and not by value
Status: NEW
Product: Samba 4.1 and newer
Classification: Unclassified
Component: Other
4.6.0rc3
All All
: P5 normal
: ---
Assigned To: Stefan Metzmacher
Samba QA Contact
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2017-02-16 15:48 UTC by Andreas Schneider
Modified: 2017-02-16 20:17 UTC (History)
2 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Andreas Schneider 2017-02-16 15:48:27 UTC
One of our tools reported that we copy a rather big structure around by value instead of pass by reference.

This could impact the performance. You might want to look this. The biggest structure passed by value is:

bin/default/librpc/gen_ndr/ndr_nbt_c.c:180: pass_by_value: Passing parameter 
_packet of type "struct netlogon_samlogon_response" (size 160 bytes) by value.