Bug 12563 - talloc fails to build if valgrind is not installed
Summary: talloc fails to build if valgrind is not installed
Status: NEW
Alias: None
Product: TALLOC
Classification: Unclassified
Component: libtalloc (show other bugs)
Version: unspecified
Hardware: All All
: P5 normal
Target Milestone: ---
Assignee: Simo Sorce
QA Contact: Samba QA Contact
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-02-06 19:18 UTC by Matthieu Patou
Modified: 2020-10-22 03:17 UTC (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Matthieu Patou 2017-02-06 19:18:57 UTC 
../lib/talloc/talloc.c:56:31: fatal error: valgrind/memcheck.h: No such file or directory
 #include <valgrind/memcheck.h>
                               ^
compilation terminated.
Comment 1 Douglas Bagnall 2020-10-22 03:17:47 UTC 
The thing is, this should only happen if valgrind SEEMS like it is installed, because

/* Special macros that are no-ops except when run under Valgrind on                                                                
 * x86.  They've moved a little bit from valgrind 1.0.4 to 1.9.4 */                                                                
#ifdef HAVE_VALGRIND_MEMCHECK_H                                                                                                    
        /* memcheck.h includes valgrind.h */                                                                                       
#include <valgrind/memcheck.h>                                                                                                     
#elif defined(HAVE_VALGRIND_H)                                                                                                     
#include <valgrind.h>                                                                                                              
#endif