After every stop of CTDB, existing entries in /etc/iproute2/rt_tables are 'doubled'. This appears to have started since https://git.samba.org/?p=samba.git;a=commit;h=0ca00267cd2620a14968961738bcd2a69b597e95 # reserved values # reserved values # reserved values # reserved values # # # # # # # # 255 local 255 local 255 local 255 local 254 main 254 main 254 main 254 main 253 default 253 default 253 default 253 default 0 unspec 0 unspec 0 unspec 0 unspec # local # local # local # local # # # # #1 inr.ruhep #1 inr.ruhep #1 inr.ruhep #1 inr.ruhep 10 ctdb.10.50.5.43 Many thanks
Wow. That's horrible. awk behaves sensibly if there is an implicit continuation in a conditions and/or action. However, if that implicit continuation is between conditions and actions then you end up with an implicit action associated with the condition, plus an action that always runs. I guess it makes sense. So, I think the only hunk where that matters is in clean_up_table_ids(), Patch to come...
Created attachment 12829 [details] Patch for master and probably 4.5 I'll see if it is possible to write a test for this. If not, I'll do some hand testing before deciding that this is the right thing to do... :-)
Barry, are you happy with a: Reported-by: Barry Evans <bevans@pixitmedia.com> tag in the commit for the fix?
Created attachment 12836 [details] Patches for v4-6
Created attachment 12837 [details] Patches for v4-5
Hi Karolin, This is ready for 4.5 and 4.6. Thanks...
(In reply to Martin Schwenke from comment #6) Pushed to autobuild-v4-{6,5}-test.
(In reply to Karolin Seeger from comment #7) Pushed to both branches. Closing out bug report. Thanks!