The regular process for removing tombstoned objects after 6 months should also remove links that have been deleted for more than 6 months.
Created attachment 12587 [details] Patch for 4.5
Created attachment 12588 [details] Patch for 4.5
Created attachment 12589 [details] Patch for 4.5
Comment on attachment 12589 [details] Patch for 4.5 This looks good. Normally, what we have here would rightly be regarded as a feature, and so not be applicable for a backport. However, this bug blocks a dbcheck bug that would require much the same changes, so instead of trying to make dbcheck cope with this also, we propose this set of tested and useful changes. The idea is that users should run 'samba-tool domain tombstones expunge' prior to dbcheck, and so avoid the issues with 'not fixing dangling forward link'.
Please apply these patches to 4.5.next
(In reply to Andrew Bartlett from comment #5) Pushed to autobuild-v4-5-test.
(In reply to Karolin Seeger from comment #6) Pushed to v4-5-test. Closing out bug report. Thanks!
When I try to execute: samba-tool domain tombstones expunge I encounter the error: ERROR(<type 'exceptions.AttributeError'>): uncaught exception - 'module' object has no attribute 'time' File "/usr/local/samba/lib/python2.7/site-packages/samba/netcmd/__init__.py", line 176, in _run return self.run(*args, **kwargs) File "/usr/local/samba/lib/python2.7/site-packages/samba/netcmd/domain.py", line 3791, in run current_time = long(time.time()) That is also described in the thread: As suggested on https://lists.samba.org/archive/samba/2016-October/204228.html Therefore, please re-open the bug so that it can be tracked.
The conflict with time.py is due to running 'make install' over an existing install that has a time.py or time.pyc in samba/netcmd/ in the install tree. This isn't a bug in this patch, just the result of not cleaning old files away during the re-install.