Bug 12288 - smbcquotas sending wrong param count when setting fs quota
Summary: smbcquotas sending wrong param count when setting fs quota
Alias: None
Product: Samba 4.1 and newer
Classification: Unclassified
Component: Tools (show other bugs)
Version: 4.5.0
Hardware: All All
: P5 minor (vote)
Target Milestone: ---
Assignee: Karolin Seeger
QA Contact: Samba QA Contact
Depends on:
Reported: 2016-09-22 13:05 UTC by Uri Simchoni
Modified: 2016-10-24 09:28 UTC (History)
2 users (show)

See Also:

git-am fix for 4.5.next (1.01 KB, patch)
2016-10-04 19:38 UTC, Uri Simchoni
jra: review+

Note You need to log in before you can comment on or make changes to this bug.
Description Uri Simchoni 2016-09-22 13:05:12 UTC
When running the command below, the TRANS2 SMB1 command contains a wrong number of parameters, which also results in out-of-bounds memory read while sending the data on the wire.

Windows and Samba servers ignore this so no functional impact is observed other than the valgrind complaint.

smbcquotas -S 'FSGLAGS:QUOTA_ENABLED' -U <credentials> //server/share
Comment 1 Uri Simchoni 2016-09-22 13:58:56 UTC
There's a number of minor bugs in that god forsaken utility, so I'll pile them all under the same bugzilla bug - 12270

*** This bug has been marked as a duplicate of bug 12270 ***
Comment 2 Uri Simchoni 2016-10-01 19:04:12 UTC
Reopning, in order to mark each issue with its own bug
Comment 3 Uri Simchoni 2016-10-04 19:38:52 UTC
Created attachment 12542 [details]
git-am fix for 4.5.next
Comment 4 Jeremy Allison 2016-10-05 18:49:17 UTC
Re-assigning to Karolin for inclusion in 4.5.next.
Comment 5 Karolin Seeger 2016-10-19 07:50:05 UTC
(In reply to Jeremy Allison from comment #4)
Pushed to autobuild-v4-5-test.
Comment 6 Karolin Seeger 2016-10-24 09:28:37 UTC
(In reply to Karolin Seeger from comment #5)
Pushed to v4-5-test.
Closing out bug report.