Bug 12271 - CTDB recovery does not terminate if no node is banned due to failure
Summary: CTDB recovery does not terminate if no node is banned due to failure
Status: RESOLVED FIXED
Alias: None
Product: Samba 4.1 and newer
Classification: Unclassified
Component: CTDB (show other bugs)
Version: 4.4.5
Hardware: All All
: P5 regression (vote)
Target Milestone: ---
Assignee: Karolin Seeger
QA Contact: Samba QA Contact
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-09-17 08:45 UTC by Amitay Isaacs
Modified: 2016-09-20 08:02 UTC (History)
4 users (show)

See Also:

Attachments
Patches for v4-4 branch (64 bytes, patch)
2016-09-17 08:46 UTC, Amitay Isaacs 		no flags Details
Patches for v4-4 branch (1.22 KB, patch)
2016-09-17 12:25 UTC, Amitay Isaacs 		martins: review+
Details
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Amitay Isaacs 2016-09-17 08:45:09 UTC 

    


    


      



        
          Comment 1
        

        
          Amitay Isaacs

        

        
        

        
          2016-09-17 08:46:30 UTC
        

      






Created attachment 12475 [details]
Patches for v4-4 branch

    


    


      



        
          Comment 2
        

        
          Amitay Isaacs

        

        
        

        
          2016-09-17 08:53:31 UTC
        

      






Hi Karolin,

I forgot to backport this patch to 4.4.x.  The fix went upstream before 4.5 was branched off, so 4.5.0 is not affected.

Would it be possible to get this in for 4.4.6?

Thanks.

    


    


      



        
          Comment 3
        

        
          Amitay Isaacs

        

        
        

        
          2016-09-17 12:25:37 UTC
        

      






Created attachment 12476 [details]
Patches for v4-4 branch

    


    


      



        
          Comment 4
        

        
          Martin Schwenke

        

        
        

        
          2016-09-17 20:20:07 UTC
        

      






Hi Karolin,

This is ready to go for 4.4.x.

Without this fix, 4.4.6 will introduce a regression, so if we can still sneak it in then that would be wonderful.

Thanks...

    


    


      



        
          Comment 5
        

        
          Karolin Seeger

        

        
        

        
          2016-09-19 08:01:59 UTC
        

      






(In reply to Martin Schwenke from comment #4)
Pushed to autobuild-v4-4-test.

    


    


      



        
          Comment 6
        

        
          Martin Schwenke

        

        
        

        
          2016-09-19 09:02:25 UTC
        

      






Thanks, Karolin!

    


    


      



        
          Comment 7
        

        
          Karolin Seeger

        

        
        

        
          2016-09-20 08:02:54 UTC
        

      






Pushed to v4-4-test.
Closing out bug report.

Thanks!