Bug 12241 - vfs_acl_common adds empty ACEs
Summary: vfs_acl_common adds empty ACEs
Status: NEEDINFO
Alias: None
Product: Samba 4.1 and newer
Classification: Unclassified
Component: VFS Modules (show other bugs)
Version: unspecified
Hardware: All All
: P5 normal (vote)
Target Milestone: ---
Assignee: Ralph Böhme
QA Contact: Samba QA Contact
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-09-06 16:34 UTC by Ralph Böhme
Modified: 2022-06-21 17:27 UTC (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ralph Böhme 2016-09-06 16:34:34 UTC 
I think we should not add ACEs with zero rights to an ACL:

$ ls -ld /shares/test
drwx------. 2 slow users 4096 Sep  5 15:45 /shares/test

$ ./bin/smbcacls -U slow%x //shares/test ""
REVISION:1
CONTROL:SR|DP
OWNER:SLOWSERVER\slow
GROUP:SLOWSERVER\users
ACL:SLOWSERVER\slow:ALLOWED/0x0/FULL
ACL:SLOWSERVER\users:ALLOWED/0x0/
ACL:Everyone:ALLOWED/0x0/

I think we should just skip the "SLOWSERVER\users" and "Everyone" in this case.

Have patch, need bug number.
Comment 1 Björn Jacke 2021-03-07 15:04:05 UTC 
I don't see a patch that went upstream for this. What is the status here?
Comment 2 Ralph Böhme 2022-06-21 08:33:01 UTC 
I had a WIP patch somewhere, but it got lost in some WIP branch I'm afraid.
Comment 3 Björn Jacke 2022-06-21 17:27:14 UTC 
what shall we do with the report now, can reproduce it (because I can't) ?