Bug 12241 – vfs_acl_common adds empty ACEs

Bug 12241 - vfs_acl_common adds empty ACEs


Summary:	vfs_acl_common adds empty ACEs

Status:	ASSIGNED

Product:	Samba 4.1 and newer
Classification:	Unclassified
Component:	VFS Modules
Version:	unspecified
Hardware:	All All

Importance:	P5 normal
Target Milestone:	---
Assigned To:	Ralph Böhme
QA Contact:	Samba QA Contact

URL:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2016-09-06 16:34 UTC by Ralph Böhme
Modified:	2016-09-06 16:34 UTC (History)
CC List:	0 users

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Ralph Böhme 2016-09-06 16:34:34 UTC

I think we should not add ACEs with zero rights to an ACL:

$ ls -ld /shares/test
drwx------. 2 slow users 4096 Sep  5 15:45 /shares/test

$ ./bin/smbcacls -U slow%x //shares/test ""
REVISION:1
CONTROL:SR|DP
OWNER:SLOWSERVER\slow
GROUP:SLOWSERVER\users
ACL:SLOWSERVER\slow:ALLOWED/0x0/FULL
ACL:SLOWSERVER\users:ALLOWED/0x0/
ACL:Everyone:ALLOWED/0x0/

I think we should just skip the "SLOWSERVER\users" and "Everyone" in this case.

Have patch, need bug number.