Bug 12194 - idmap_script: missing "IDTOSID" argument in scripts command line
Summary: idmap_script: missing "IDTOSID" argument in scripts command line
Status: RESOLVED FIXED
Alias: None
Product: Samba 4.1 and newer
Classification: Unclassified
Component: Winbind (show other bugs)
Version: 4.5.0rc3
Hardware: All All
: P5 regression (vote)
Target Milestone: 4.5
Assignee: Karolin Seeger
QA Contact: Samba QA Contact
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-08-29 15:22 UTC by Björn Baumbach
Modified: 2016-09-07 15:11 UTC (History)
2 users (show)

See Also:

Attachments
Patch for v4-5-test (1.59 KB, patch)
2016-09-07 06:54 UTC, Stefan Metzmacher 		obnox: review+
asn: review+
Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Björn Baumbach 2016-08-29 15:22:58 UTC 
According to the documentation the idmap script commands should look like
"IDTOSID UID xxxx" instead of "UID xxxx".

Existing scripts, used by the idmap module, might not work.
    
The changes were introduced with the commit b4239ca096738f553b0f9d7fa6aaa4219b72ef7f "idmap_script: Parallelize script calls"

I'll send a patch to the samba-technical mailing list, soon.
Comment 1 Stefan Metzmacher 2016-09-07 06:54:38 UTC 
Created attachment 12449 [details]
Patch for v4-5-test
Comment 2 Andreas Schneider 2016-09-07 07:47:21 UTC 
Comment on attachment 12449 [details]
Patch for v4-5-test

LGTM
Comment 3 Stefan Metzmacher 2016-09-07 09:05:32 UTC 
Pushed to autobuild-v4-5-test.
Comment 4 Stefan Metzmacher 2016-09-07 15:11:02 UTC 
Pushed to v4-5-test