Bug 12187 - Backport changes for partial attribute set calculation for 4.5
Summary: Backport changes for partial attribute set calculation for 4.5
Alias: None
Product: Samba 4.1 and newer
Classification: Unclassified
Component: AD: LDB/DSDB/SAMDB (show other bugs)
Version: 4.5.0rc2
Hardware: All All
: P5 normal (vote)
Target Milestone: 4.5
Assignee: Karolin Seeger
QA Contact: Samba QA Contact
Depends on:
Reported: 2016-08-28 23:33 UTC by Garming Sam
Modified: 2016-09-06 06:16 UTC (History)
3 users (show)

See Also:

Backport for 4.5 (49.63 KB, patch)
2016-08-29 04:49 UTC, Garming Sam
abartlet: review+
garming: review? (metze)

Note You need to log in before you can comment on or make changes to this bug.
Description Garming Sam 2016-08-28 23:33:36 UTC
A prefixmap needs to be sent alongside any partial attribute set sent in a GetNCChanges request, in order to correctly calculate which attributes need to be returned. 

Although the docs says that this is a strict requirement, without the prefixmap, replicating from Windows will silently omit attributes such as name or ntSecurityDescriptor without returning any errors. Furthermore, attids retain their fallback to the default mapping ranges (all of which may cause subtle breakages).
Comment 1 Garming Sam 2016-08-29 04:49:50 UTC
Created attachment 12416 [details]
Backport for 4.5
Comment 2 Stefan Metzmacher 2016-08-29 05:36:12 UTC
Pushed to autobuild-v4-5-test.
Comment 3 Stefan Metzmacher 2016-09-06 06:16:41 UTC
Included in 4.5.0rc3