Bug 12173 - memory leak around poptGetOptArg()
memory leak around poptGetOptArg()
Status: NEW
Product: rsync
Classification: Unclassified
Component: core
All All
: P5 normal
: ---
Assigned To: Wayne Davison
Rsync QA Contact
Depends on:
  Show dependency treegraph
Reported: 2016-08-24 13:34 UTC by T Yamada
Modified: 2016-08-24 13:34 UTC (History)
0 users

See Also:


Note You need to log in before you can comment on or make changes to this bug.
Description T Yamada 2016-08-24 13:34:48 UTC
Description of problem:
    In poptGetOptArg(), con->os->nextArg is set to be NULL, which means the returned memory is out of popt management.
    We have to free it.

Version-Release number of selected component (if applicable):
    rsync 3.0.6
    (perhaps the latest version is also affected, according to the source code)

How reproducible:
    always, with "--chmod=u+x" flag

Steps to Reproduce:
    valgrind --tool=memcheck rsync --chmod=u+x

Actual results:
    valgrind indicates memory leak.

Expected results:
    no memory leak, at least no big ones.

Additional info:
    Carefully read, it looks like POPT_ARG_STRING values also have to be freed (such as shell_cmd and logfile_name).
    But since they are global variables, they are represented as "still reachable".
    Further investigation is required for this side.