Bug 12143 - misnamed attribute in samba_kcc causes exception in unusual circumstances
misnamed attribute in samba_kcc causes exception in unusual circumstances
Product: Samba 4.1 and newer
Classification: Unclassified
All All
: P5 minor
: ---
Assigned To: Karolin Seeger
Samba QA Contact
Depends on:
  Show dependency treegraph
Reported: 2016-08-11 23:57 UTC by Douglas Bagnall
Modified: 2016-08-29 02:46 UTC (History)
3 users (show)

See Also:

the patch (1.07 KB, patch)
2016-08-11 23:59 UTC, Douglas Bagnall
no flags Details
backport for 4.5 (1.27 KB, patch)
2016-08-25 02:37 UTC, Garming Sam
dbagnall: review+

Note You need to log in before you can comment on or make changes to this bug.
Description Douglas Bagnall 2016-08-11 23:57:16 UTC
See the impending patch.

Autobuild found it but it would never break typically, where the database has the options value.

/memdisk/autobuild/fl/b162967/samba/source4/scripting/bin/samba_kcc:     attempt_live_connections=opts.attempt_live_connections)
/memdisk/autobuild/fl/b162967/samba/source4/scripting/bin/samba_kcc:   File "bin/python/samba/kcc/__init__.py", line 2641, in run
/memdisk/autobuild/fl/b162967/samba/source4/scripting/bin/samba_kcc:     self.intrasite()
/memdisk/autobuild/fl/b162967/samba/source4/scripting/bin/samba_kcc:   File "bin/python/samba/kcc/__init__.py", line 2410, in intrasite
/memdisk/autobuild/fl/b162967/samba/source4/scripting/bin/samba_kcc:     detect_stale)
/memdisk/autobuild/fl/b162967/samba/source4/scripting/bin/samba_kcc:   File "bin/python/samba/kcc/__init__.py", line 2093, in construct_intrasite_graph
/memdisk/autobuild/fl/b162967/samba/source4/scripting/bin/samba_kcc:     if gc_only and not dc_s.is_gc():
/memdisk/autobuild/fl/b162967/samba/source4/scripting/bin/samba_kcc:   File "bin/python/samba/kcc/kcc_utils.py", line 622, in is_gc
/memdisk/autobuild/fl/b162967/samba/source4/scripting/bin/samba_kcc:     if (self.options & dsdb.DS_NTDSDSA_OPT_IS_GC) != 0:
/memdisk/autobuild/fl/b162967/samba/source4/scripting/bin/samba_kcc: AttributeError: 'DirectoryServiceAgent' object has no attribute 'options'
../source4/dsdb/kcc/kcc_periodic.c:646: Failed samba_kcc - NT_STATUS_ACCESS_DENIED
Comment 1 Douglas Bagnall 2016-08-11 23:59:48 UTC
Created attachment 12363 [details]
the patch
Comment 2 Garming Sam 2016-08-25 02:37:18 UTC
Created attachment 12400 [details]
backport for 4.5
Comment 3 Douglas Bagnall 2016-08-26 03:18:43 UTC
Assigned to Karolin for 4.5
Comment 4 Stefan Metzmacher 2016-08-28 16:12:14 UTC
Pushed to autobuild-v4-5-test.
Comment 5 Stefan Metzmacher 2016-08-29 02:46:20 UTC
Pushed to v4-5-test.