Bug 12113 - ctdb_mutex_fcntl_helper can wait forever when reparented to init
Summary: ctdb_mutex_fcntl_helper can wait forever when reparented to init
Status: RESOLVED FIXED
Alias: None
Product: CTDB 2.5.x or older
Classification: Unclassified
Component: ctdb (show other bugs)
Version: 4.5.0rc
Hardware: All All
: P5 normal
Target Milestone: ---
Assignee: Karolin Seeger
QA Contact: Samba QA Contact
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-08-05 06:17 UTC by Martin Schwenke
Modified: 2016-08-11 08:33 UTC (History)
1 user (show)

See Also:

Attachments
Patch for 4.5rc (2.09 KB, patch)
2016-08-09 03:20 UTC, Martin Schwenke 		amitay: review+
Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Schwenke 2016-08-05 06:17:50 UTC 
If the helper is reparented to init before it gets ppid() then in certain circumstances it will loop forever while holding the mutex, even though its original parent is long gone.  This can happen if the helper is started just as the parent is killed during shutdown.
Comment 1 Martin Schwenke 2016-08-09 03:20:54 UTC 
Created attachment 12332 [details]
Patch for 4.5rc

Please apply to 4.5 after BZ12110 - applying in BZ number order is easiest :-)
Comment 2 Amitay Isaacs 2016-08-09 04:40:17 UTC 
Hi Karolin,

Here are patches for v4-5.
Comment 3 Karolin Seeger 2016-08-09 08:07:21 UTC 
Pushed to autobuild-v4-5-test.
Comment 4 Karolin Seeger 2016-08-11 08:33:53 UTC 
(In reply to Karolin Seeger from comment #3)
Pushed to v4-5-test.
Closing out bug report.

Thanks!