ctdb-tests should be moved to the libexec directory and not be installed in /usr/lib/ctdb-tests. Patch will follow.
Should this be assigned to the CTDB product?
(In reply to Martin Schwenke from comment #1) Done.
Created attachment 12312 [details] patch for 4.5
Created attachment 12313 [details] patch for 4.4
I'm keen to test the 4.4 patch before review, just to make sure there's nothing unexpected missing. I might get time on the weekend, but otherwise it will be Monday. Monday will be a busy day...
Hi Karolin, This is ready for 4.4 and 4.5. Thanks...
(In reply to Martin Schwenke from comment #6) Pushed to autobuild-v4-[4|5]-test.
(In reply to Karolin Seeger from comment #7) Pushed to both branches. Closing out bug report. Thanks!
Thinking about this right now, this should have been gone in a major release only and not in a maintenance release. Another question: datadir points to conf.env.CTDB_TEST_DATADIR = os.path.join(conf.env.EXEC_PREFIX, 'share/ctdb-tests') Wondering if it should not be share/ctdb/tests like in the libexecdir.
(In reply to Karolin Seeger from comment #9) > Thinking about this right now, this should have been gone in a major > release only and not in a maintenance release. The affected paths are internal-only, so there's really no danger of incompatibility. I'm pretty sure Andreas wanted to see these changes go in as soon as possible to improve packaging for distros, > Another question: > datadir points to > conf.env.CTDB_TEST_DATADIR = os.path.join(conf.env.EXEC_PREFIX, > 'share/ctdb-tests') > Wondering if it should not be share/ctdb/tests like in the > libexecdir. Definitely! It is something I have planned. I think it involves fairly trivial changes to the wscript file and RPM template. I didn't do it at the time because there was no pressing need. There are some things that are currently installed in /etc/ctdb/ that should probably go in /usr/share/ctdb/, since they really aren't configuration. So /usr/share/ctdb/ will happen some time anyway. However, some of it is tricky to get right for both in-tree testing and installation. Time, time, time... :-)
I have a patch ready for /usr/local/share/ctdb/tests/. It was easier than I thought. I'm reassigning this to me and will add the extra patch.
Created attachment 12582 [details] Additional patch for 4.5
Created attachment 12583 [details] Additional patch for 4.4
Hi Karolin, This is ready again for v4-4 and v4-5. Only the additional patch for each branch.
(In reply to Amitay Isaacs from comment #14) Pushed to autobuild-v4-{5,4}-test.
(In reply to Karolin Seeger from comment #15) Pushed to both branches. Closing out bug report. Thanks!