Bug 1206 - [PATCH] netatalk vfs causes segfaults in samba
Summary: [PATCH] netatalk vfs causes segfaults in samba
Alias: None
Product: Samba 3.0
Classification: Unclassified
Component: Config Files (show other bugs)
Version: 3.0.2a
Hardware: All All
: P3 normal
Target Milestone: none
Assignee: Karolin Seeger
QA Contact:
Depends on:
Reported: 2004-03-22 13:24 UTC by Patrick Bihan-Faou
Modified: 2010-03-11 02:57 UTC (History)
0 users

See Also:

A patch to the function adding '.AppleDouble' to the hide list (689 bytes, patch)
2004-03-22 13:26 UTC, Patrick Bihan-Faou
no flags Details
Patch for v3-5-test branch (825 bytes, patch)
2010-03-09 21:27 UTC, SATOH Fumiyasu
no flags Details
git am patch for 3.3.x (820 bytes, patch)
2010-03-10 18:16 UTC, Jeremy Allison
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Patrick Bihan-Faou 2004-03-22 13:24:12 UTC
The netatalk vfs tries to add '.AppleDouble' to the hide_list for the current
connection, however it fails to add an empty entry at the end of the list.

This causes a segfault in 'is_in_path' (lib/util.c) when it tries to match a
filename against the hide list.
Comment 1 Patrick Bihan-Faou 2004-03-22 13:26:06 UTC
Created attachment 449 [details]
A patch to the function adding '.AppleDouble' to the hide list

This patch fixes the netatalk vfs to properly terminate the hide_list with a
null entry after adding the '.AppleDouble' name to it.
Comment 2 Gerald (Jerry) Carter (dead mail address) 2005-11-14 09:25:27 UTC
database cleanup
Comment 3 SATOH Fumiyasu 2010-03-09 21:27:33 UTC
Created attachment 5480 [details]
Patch for v3-5-test branch

This bug is reproduceable with Samba 3.2.15 and 3.5.1.
I've created a patch for Samba 3.5.1.
Comment 4 Jeremy Allison 2010-03-10 18:12:32 UTC
Perfectly correct - thanks ! Will ensure this gets into all active branches.

Comment 5 Jeremy Allison 2010-03-10 18:15:37 UTC
Karolin the patch applies cleanly to both 3.5.2 and 3.4.x.

Please apply.

Comment 6 Jeremy Allison 2010-03-10 18:16:04 UTC
Created attachment 5486 [details]
git am patch for 3.3.x

Patch for 3.3.x.

Comment 7 Karolin Seeger 2010-03-11 02:57:57 UTC
Pushed patch to v3-5-test and v3-4-test (3.3 is in the security fixes only mode).
Closing out bug report.

Thanks a lot for providing the patch!