Bug 12041 - Support the new proto_tree_add_bitmask_with_flags() routine
Summary: Support the new proto_tree_add_bitmask_with_flags() routine
Status: RESOLVED FIXED
Alias: None
Product: Samba 4.1 and newer
Classification: Unclassified
Component: PIDL and libndr (show other bugs)
Version: unspecified
Hardware: All All
: P5 enhancement (vote)
Target Milestone: ---
Assignee: Samba QA Contact
QA Contact: Jelmer Vernooij
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-07-27 23:28 UTC by Guy Harris
Modified: 2025-02-20 01:41 UTC (History)
1 user (show)

See Also:

Attachments
Patch to add proto_tree_add_bitmask_with_flags() support (4.06 KB, patch)
2016-07-27 23:28 UTC, Guy Harris 		no flags Details
outstanding patches for pidl/lib/Parse/Pidl/Wireshark/ (11.13 KB, patch)
2019-03-06 22:15 UTC, Douglas Bagnall 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Guy Harris 2016-07-27 23:28:50 UTC 
Created attachment 12294 [details]
Patch to add proto_tree_add_bitmask_with_flags() support

From Wireshark commit:

commit 9a5e6a6884b2369527638fecd49c4c58d8c10378
Author: Michael Mann <mmann78@netscape.net>
Date:   Wed Jun 15 15:35:51 2016 -0400

    DCE/RPC proto_tree_add_boolean -> proto_tree_add_bitmask_with_flags
    
    Change-Id: I8891ec90244ffd9609d8443df631a7c8e6453b7e
    Reviewed-on: https://code.wireshark.org/review/15942
    Petri-Dish: Michael Mann <mmann78@netscape.net>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
    Reviewed-by: Michael Mann <mmann78@netscape.net>
Comment 1 Douglas Bagnall 2019-03-06 22:15:56 UTC 
Created attachment 14905 [details]
outstanding patches for pidl/lib/Parse/Pidl/Wireshark/

Some rough treatment of git gave me a list of 5 patches that Wireshark might want in Samba PIDL. Are these correct?

[1/5] is shorn of context so its commit message needs help.

BTW, we prefer patches generated by `git format-patch --stdout` rather than `git diff`, because it preserves the authorship and commit messages.


This patchset would also deal with #12042.

Are there other things I am missing?
Comment 2 Andrew Bartlett 2019-04-01 21:20:43 UTC 
Moving PIDL bugs into Samba as we do not release PIDL separately.
Comment 3 Douglas Bagnall 2025-02-20 01:41:56 UTC 
> commit 9a5e6a6884b2369527638fecd49c4c58d8c10378
> Author: Michael Mann <mmann78@netscape.net>
> Date:   Wed Jun 15 15:35:51 2016 -0400
> 
>     DCE/RPC proto_tree_add_boolean -> proto_tree_add_bitmask_with_flags


This went in as

commit 3c97ad41c3ba440e7bb6bf7f5132aeb9032f08e9
Author: John Thacker <johnthacker@gmail.com>
Date:   Tue Jun 25 18:30:22 2024 -0400

    pidl:Wireshark Use proto_tree_add_bitmask_with_flags
    
via https://gitlab.com/samba-team/samba/-/merge_requests/3683

Other Wireshark patches arrived in https://gitlab.com/samba-team/samba/-/merge_requests/3699

which discusses whether there might be more that could be brought across.

I'll close this bug.