Bug 12033 - smbd should support copy_file_range() for FSCTL_SRV_COPYCHUNK
smbd should support copy_file_range() for FSCTL_SRV_COPYCHUNK
Status: NEW
Product: Samba 4.1 and newer
Classification: Unclassified
Component: File services
unspecified
All All
: P5 enhancement
: ---
Assigned To: Samba QA Contact
Samba QA Contact
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2016-07-25 09:29 UTC by Björn Jacke
Modified: 2017-06-15 11:32 UTC (History)
4 users (show)

See Also:


Attachments
patch for master (5.61 KB, patch)
2017-02-09 08:13 UTC, Björn Jacke
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Björn Jacke 2016-07-25 09:29:02 UTC
copy_file_range is supported since kernel 4.5. We should check if this call is supported and use it for server side copychung operation.

Interesting also for Kernel 4.7, where the NFS client code also supports that call and can speed up Samba servers with NFS file stores.

Side note: if copy_file_range support is found, btrfs should not override the copy_chunk functions but use the generic code.
Comment 1 Björn Jacke 2016-09-07 09:35:54 UTC
with linux kernel 4.8 even xfs will profit immensely from the use of copy_file_range with the introduction of reflink copies.
Comment 2 Björn Jacke 2017-02-09 08:13:29 UTC
Created attachment 12912 [details]
patch for master
Comment 3 Ralph Böhme 2017-06-02 14:17:48 UTC
As just discussed on the phone:

* in vfs_default.c:vfswrap_copy_chunk_send() we should use copy_file_range() if flags does not contain VFS_COPY_CHUNK_FL_MUST_CLONE

* if flags contains VFS_COPY_CHUNK_FL_MUST_CLONE we must use the IOC_CLONE_RANGE ioctl()

* we then can remove the copy_chunk handler from vfs_btrfs