Bug 11978 - mkstemp failed: File name too long (36) when filename is under the limit
Summary: mkstemp failed: File name too long (36) when filename is under the limit
Status: NEW
Alias: None
Product: rsync
Classification: Unclassified
Component: core (show other bugs)
Version: 3.1.1
Hardware: All All
: P5 normal (vote)
Target Milestone: ---
Assignee: Wayne Davison
QA Contact: Rsync QA Contact
Depends on:
Reported: 2016-06-15 20:16 UTC by Syr
Modified: 2018-06-25 11:08 UTC (History)
1 user (show)

See Also:


Note You need to log in before you can comment on or make changes to this bug.
Description Syr 2016-06-15 20:16:15 UTC
Using mkstemp adds on 7 characters to the filename, which creates a problem when the filename is below, but close to, the limit of the filesystem.

You can see this when rsync'ing from one ecryptfs filesystem to another, which will fail even though both have the exact same 143-byte filename limit, if a filename consists of more than 136 bytes.

Is there any reason the .XXXXXX in the argument to mkstemp can't *replace* the last 7 characters in the filename, instead of being appended to it?
Comment 1 Syr 2016-06-15 20:27:11 UTC

Wait, it actually adds 8 characters to it in total, there's a dot prepended at the beginning to.
Comment 2 Syr 2016-06-15 20:36:10 UTC
Triple post. Shouldn't it also use e.g. f_namelen from statfs() at runtime instead of a compile-time constant?

And MAXPATHLEN doesn't even seem to reflect reality, since it's not actually limited to that on Linux.
Comment 3 Mauro Molinari 2018-06-25 11:08:25 UTC
I'm also encountering problems regarding mkstemp "file name too long error" when rsyncing to an ecryptfs filesystem. Probably, rsync should try to handle this in a smarter way.
A secondary problem I see is that, even if this error is given, the whole file is transferred from source to target anyway, although not actually saved on the target. So, if the file is huge and the bandwidth is low, this is a serious waste.

Using rsync 3.0.9 on local side (target) and rsync 3.1.1 on remote side (source).