Bug 11958 - missing Protocol Versions in location source3_lib_sessionid_tdb.c
Summary: missing Protocol Versions in location source3_lib_sessionid_tdb.c
Status: RESOLVED FIXED
Alias: None
Product: Samba 4.1 and newer
Classification: Unclassified
Component: File services (show other bugs)
Version: 4.4.3
Hardware: All All
: P5 normal (vote)
Target Milestone: ---
Assignee: Samba QA Contact
QA Contact: Samba QA Contact
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-06-08 12:30 UTC by Michael Zoon
Modified: 2017-07-04 19:20 UTC (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Zoon 2016-06-08 12:30:31 UTC 
Please can the missing protocols be added to samba upcoming 4.3.10 release on
location source3/lib/sessionid_tdb.c.

we need 

--- source3/lib/sessionid_tdb.c.orig	2015-07-21 11:47:49.000000000 +0200
+++ source3/lib/sessionid_tdb.c	2016-04-14 15:20:01.000000000 +0200
@@ -67,6 +67,12 @@
 	case SMB3_DIALECT_REVISION_302:
 		fstrcpy(session.protocol_ver, "SMB3_02");
 		break;
+	case SMB3_DIALECT_REVISION_310:
+		fstrcpy(session.protocol_ver, "SMB3_10");
+		break;
+	case SMB3_DIALECT_REVISION_311:
+		fstrcpy(session.protocol_ver, "SMB3_11");
+		break;
 	default:
 		fstr_sprintf(session.protocol_ver, "Unknown (0x%04x)",
 			     global->connection_dialect);

I use this for a while now without any problems.

regards,
zoon01
Comment 1 Stefan Metzmacher 2017-07-04 19:20:07 UTC 
Fixed in 4.4 and higher