Bug 11814 - man-copy Make target missing rsync.1 and rsyncd.conf.5 dependencies
man-copy Make target missing rsync.1 and rsyncd.conf.5 dependencies
Status: RESOLVED INVALID
Product: rsync
Classification: Unclassified
Component: core
3.1.2
All All
: P5 trivial
: ---
Assigned To: Wayne Davison
Rsync QA Contact
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2016-03-30 03:06 UTC by Brant Gurganus
Modified: 2016-04-17 18:55 UTC (History)
0 users

See Also:


Attachments
patch adding man page dependencies (488 bytes, patch)
2016-03-30 03:14 UTC, Brant Gurganus
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Brant Gurganus 2016-03-30 03:06:34 UTC
I currently do not have yodl2man installed. I was building rsync from the git repository to verify a different change. The cp commands relying on the existence of rsync.1 and rsyncd.conf.5 failed since those files did not exist. That man-copy target should rely on rsync.1 and rsyncd.conf.5 it seems.
Comment 1 Brant Gurganus 2016-03-30 03:14:22 UTC
Created attachment 11943 [details]
patch adding man page dependencies

This patch makes the two files dependencies triggering them to be generated. They still fail in my case since I don't have yodl2man, but they'd be generated if I did.

If the intention is to use the man files if there but ignore them if not, then the patch would have to be different.
Comment 2 Wayne Davison 2016-04-17 18:55:19 UTC
The "man" target depends on the *.1 & *.5 files so that they get created. The "man-copy" target just tries to copy pre-existing files from the srcdir (which is useful if someone is building an unchanged tar distribution) -- it just outputs a non-fatal error if they aren't found. I've tweaked the Makefile to output a less alarming warning while still mentioning when the man pages did not get created.

For the case of a later install of yodl, configure would need to be rerun to change the Makefile's "all" target to depend on "man" instead of "man-copy" (or the user could run "make man" explicitly).