Bug 11813 - m4/socklen_t.m4 uses obsolete AC_TRY_COMPILE macro
Summary: m4/socklen_t.m4 uses obsolete AC_TRY_COMPILE macro
Status: RESOLVED FIXED
Alias: None
Product: rsync
Classification: Unclassified
Component: core (show other bugs)
Version: 3.1.2
Hardware: All All
: P5 trivial (vote)
Target Milestone: ---
Assignee: Wayne Davison
QA Contact: Rsync QA Contact
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-03-30 02:52 UTC by Brant Gurganus
Modified: 2016-04-17 18:22 UTC (History)
0 users

See Also:

Attachments
trivial patch replacing obsolete macro with non-obsolete replacement (762 bytes, patch)
2016-03-30 02:58 UTC, Brant Gurganus 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Brant Gurganus 2016-03-30 02:52:23 UTC 
socklen_t.m4 uses the AC_TRY_COMPILE macro that is labeled obsolete and replaced trivially with a AC_COMPILE_IFELSE construct.

This prevents autoreconf --warnings=all,error from succeeding.
Comment 1 Brant Gurganus 2016-03-30 02:58:16 UTC 
Created attachment 11942 [details]
trivial patch replacing obsolete macro with non-obsolete replacement

I'm surprised I missed this when I previously submitted a patch to update the autoconf macros. Anyhow, after this change autoreconf --warnings=all,error will complete successfully for me. Configure appeared to run fine with the regenerated configure script.
Comment 2 Wayne Davison 2016-04-17 18:22:42 UTC 
Thanks for pointing that out and for the patch.  Applied to git.