Bug 11697 - test suite samba3.blackbox.dfree_quota fails if run by some users
Summary: test suite samba3.blackbox.dfree_quota fails if run by some users
Status: RESOLVED FIXED
Alias: None
Product: Samba 4.1 and newer
Classification: Unclassified
Component: Other (show other bugs)
Version: unspecified
Hardware: All All
: P5 normal (vote)
Target Milestone: ---
Assignee: Karolin Seeger
QA Contact: Samba QA Contact
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-01-27 20:27 UTC by Uri Simchoni
Modified: 2016-02-04 08:00 UTC (History)
3 users (show)

See Also:

Attachments
proposed fix for 4.4.next (1.39 KB, patch)
2016-01-28 05:29 UTC, Uri Simchoni 		jra: review+
Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Uri Simchoni 2016-01-27 20:27:39 UTC 
The samba3.blackbox.dfree_quota test suite, like many blackbox test suites, uses the username of the user running the test. Wrong usage of the echo command while analyzing command output causes the test to fail.

For example, if the command output was 'FILESERVER\amitay', issuing 'echo "$out"' causes the shell (built-in echo command) to treat \a as an escape sequence rather than two distinct characters, whereas with FILESERVER\uri, the \u are treated as two characters.
Comment 1 Uri Simchoni 2016-01-28 05:29:48 UTC 
Created attachment 11793 [details]
proposed fix for 4.4.next
Comment 2 Jeremy Allison 2016-01-28 21:58:44 UTC 
Comment on attachment 11793 [details]
proposed fix for 4.4.next

LGTM.
Comment 3 Jeremy Allison 2016-01-28 21:59:08 UTC 
Re-assigning to Karolin for inclusion in 4.4.0.
Comment 4 Karolin Seeger 2016-02-02 11:03:44 UTC 
(In reply to Jeremy Allison from comment #3)
Pushed to autobuild-v4-4-test.
Comment 5 Karolin Seeger 2016-02-04 08:00:23 UTC 
(In reply to Karolin Seeger from comment #4)
Pushed to v4-4-test.
Closing out bug report.

Thanks!