Bug 11594 - unnecessary build time dependency (mkproto.pl, perl)
Summary: unnecessary build time dependency (mkproto.pl, perl)
Alias: None
Product: rsync
Classification: Unclassified
Component: core (show other bugs)
Version: 3.1.2
Hardware: All All
: P5 normal (vote)
Target Milestone: ---
Assignee: Wayne Davison
QA Contact: Rsync QA Contact
Depends on:
Reported: 2015-11-09 14:44 UTC by Petar Bogdanovic
Modified: 2020-07-26 08:42 UTC (History)
0 users

See Also:


Note You need to log in before you can comment on or make changes to this bug.
Description Petar Bogdanovic 2015-11-09 14:44:34 UTC
When building rsync from its distfile,

   perl ./mkproto.pl ./*.c ./lib/compat.c

will always run, even though up-to-date versions of proto.h and
proto.h-tstamp are provided by the distfile.

The reason is the following target:

   proto.h-tstamp: $(srcdir)/*.c $(srcdir)/lib/compat.c config.h
           perl $(srcdir)/mkproto.pl $(srcdir)/*.c $(srcdir)/lib/compat.c

which declares config.h (created by the configure script, obviously
always newer than the proto.h file provided by the distfile) as its
source without actually using the file.

Removing config.h from the list of proto.h-tstamp sources eliminates 
the need for perl when building rsync from its distfile.
Comment 1 Wayne Davison 2020-07-26 08:42:46 UTC
Fixed.  Thanks!

(The need for perl was also changed into a need for awk/gawk/nawk for the mkproto script as well as for some other new data-harvesting scripts.)