The Samba-Bugzilla – Bug 11569
winbindd crashes with samlogon for trusted domain user
Last modified: 2015-11-17 10:30:59 UTC
Created attachment 11529 [details] patch file winbindd will crash in at least 4.1.x & 4.2.x when attempting to authenticate a trusted non 'own' domain user with samlogon (e.g. if we fallback from Kerberos) Note: the core does not happen in 4.3 or master as cm_connect_netlogon seems to have changed quite a bit in these versions and this scenario is avoided.
Created attachment 11564 [details] patch (1 or 2) file for 4.2.x
Created attachment 11565 [details] patch (2 of 2) file for 4.2.x
Created attachment 11571 [details] patch (1 of 2)
Created attachment 11581 [details] (patch 1 or 2) cherry-pick from master to 4.2.5
Created attachment 11582 [details] patch (2 of 2) cherry-pick from master to 4.2.5
Created attachment 11583 [details] patch (1 of 2) cherry-pick from master to 4.3.1
Created attachment 11584 [details] (patch 2 of 2) cherry-pick from master to 4.3.1
Comment on attachment 11581 [details] (patch 1 or 2) cherry-pick from master to 4.2.5 LGTM - but next time put the two patches together in one attachment by doing: git format-patch --stdout <refspec1>..<refspec2> > /tmp/patch-file. Thanks ! Jeremy.
Comment on attachment 11582 [details] patch (2 of 2) cherry-pick from master to 4.2.5 NAK - this won't compile on 4.2.x as DBG_NOTICE/DBG_WARNING etc. don't exist on 4.2. Just use DEBUG(3,("msg" instead.
Comment on attachment 11583 [details] patch (1 of 2) cherry-pick from master to 4.3.1 LGTM.
Comment on attachment 11584 [details] (patch 2 of 2) cherry-pick from master to 4.3.1 LGTM.
Created attachment 11588 [details] combined patch (of the two commits) from 4.2.5 from master replaced the DEBUG_NOTICE with DEBUG(3,...) sorry about that, should have known better and should have checked, friday afternoon rush :(
Re-assigning to Karolin for inclusion in 4.3.next, 4.2.next.
(In reply to Jeremy Allison from comment #13) Pushed to autobuild-v4-[3|2]-test.
(In reply to Karolin Seeger from comment #14) Pushed to both branches. Closing out bug report. Thanks!