Bug 11568 - 'STATUS=' in debug messages
Summary: 'STATUS=' in debug messages
Status: RESOLVED FIXED
Alias: None
Product: Samba 4.1 and newer
Classification: Unclassified
Component: Other (show other bugs)
Version: 4.8.0rc2
Hardware: All All
: P5 normal (vote)
Target Milestone: ---
Assignee: Karolin Seeger
QA Contact: Samba QA Contact
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-10-22 10:27 UTC by Marcos Mello
Modified: 2019-04-03 10:33 UTC (History)
3 users (show)

See Also:

Attachments
Fix (1.43 KB, patch)
2018-02-04 09:54 UTC, Marcos Mello 		no flags Details
Fix 2 (1.48 KB, patch)
2018-02-08 10:21 UTC, Marcos Mello 		no flags Details
patch for 4.9 (50 bytes, patch)
2019-03-20 16:08 UTC, Andreas Schneider 		no flags Details
patch for 4.8 (50 bytes, patch)
2019-03-20 16:09 UTC, Andreas Schneider 		no flags Details
patch for 4.9 and 4.8 (2.61 KB, patch)
2019-03-20 17:21 UTC, Andreas Schneider 		ab: review+
Details
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Marcos Mello 2015-10-22 10:27:50 UTC 
In lib/util/become_daemon.c, daemon_ready() DEBUG logging needs a new line.

 128 _PUBLIC_ void daemon_ready(const char *daemon)
 129 {
 130         if (daemon == NULL) {
 131                 daemon = "Samba";
 132         }
 133 #ifdef HAVE_SYSTEMD
 134         sd_notifyf(0, "READY=1\nSTATUS=%s: ready to serve connections...", daemon);
 135 #endif
 136         DEBUG(0, ("STATUS=daemon '%s' finished starting up and ready to serve connections", daemon));
 137 }

BTW, are the 'STATUS=' in these DEBUGs necessary? Copy and paste error from sd_notifyf?
Comment 1 Marcos Mello 2015-10-24 18:22:48 UTC 
So the new line issue is already fixed (55c279f0).

The 'STATUS=' occurrences are still there though.
Comment 2 Marcos Mello 2018-02-04 09:54:54 UTC 
Created attachment 13939 [details]
Fix
Comment 3 Marcos Mello 2018-02-08 10:21:49 UTC 
Created attachment 13947 [details]
Fix 2

Updated patch with s-o-b.
Comment 4 Andreas Schneider 2019-03-20 16:08:26 UTC 
Created attachment 14960 [details]
patch for 4.9
Comment 5 Andreas Schneider 2019-03-20 16:09:14 UTC 
Created attachment 14961 [details]
patch for 4.8
Comment 6 Andreas Schneider 2019-03-20 16:09:31 UTC 
This has already been fixed in Samba 4.10
Comment 7 Andreas Schneider 2019-03-20 17:21:51 UTC 
Created attachment 14964 [details]
patch for 4.9 and 4.8
Comment 8 Andreas Schneider 2019-03-20 21:30:24 UTC 
Karolin, please apply the patch to the relevant branches. Thanks!
Comment 9 Karolin Seeger 2019-03-21 12:04:01 UTC 
(In reply to Andreas Schneider from comment #8)
Pushed to autobuild-v4-{9,8}-test.
Comment 10 Karolin Seeger 2019-04-03 10:33:21 UTC 
(In reply to Karolin Seeger from comment #9)
Pushed to both branches.
Closing out bug report.

Thanks!