Bug 11568 - 'STATUS=' in debug messages
'STATUS=' in debug messages
Status: NEW
Product: Samba 4.1 and newer
Classification: Unclassified
Component: Other
unspecified
All All
: P5 normal
: ---
Assigned To: Andrew Bartlett
Samba QA Contact
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2015-10-22 10:27 UTC by Marcos Mello
Modified: 2015-10-24 18:22 UTC (History)
1 user (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Marcos Mello 2015-10-22 10:27:50 UTC
In lib/util/become_daemon.c, daemon_ready() DEBUG logging needs a new line.

 128 _PUBLIC_ void daemon_ready(const char *daemon)
 129 {
 130         if (daemon == NULL) {
 131                 daemon = "Samba";
 132         }
 133 #ifdef HAVE_SYSTEMD
 134         sd_notifyf(0, "READY=1\nSTATUS=%s: ready to serve connections...", daemon);
 135 #endif
 136         DEBUG(0, ("STATUS=daemon '%s' finished starting up and ready to serve connections", daemon));
 137 }

BTW, are the 'STATUS=' in these DEBUGs necessary? Copy and paste error from sd_notifyf?
Comment 1 Marcos Mello 2015-10-24 18:22:48 UTC
So the new line issue is already fixed (55c279f0).

The 'STATUS=' occurrences are still there though.