Bug 11526 - [samba-tool] testparm doesn't hide synonyms
Summary: [samba-tool] testparm doesn't hide synonyms
Status: RESOLVED FIXED
Alias: None
Product: Samba 4.1 and newer
Classification: Unclassified
Component: Tools (show other bugs)
Version: 4.2.3
Hardware: All All
: P5 normal (vote)
Target Milestone: ---
Assignee: Karolin Seeger
QA Contact: Samba QA Contact
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-09-19 18:40 UTC by Stefan Metzmacher
Modified: 2015-10-12 18:57 UTC (History)
2 users (show)

See Also:

Attachments
Patch for v4-3-test (3.71 KB, patch)
2015-09-21 18:13 UTC, Stefan Metzmacher 		obnox: review+
Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Stefan Metzmacher 2015-09-19 18:40:02 UTC 
The functions lp_dump() and lpcfg_dump() don't hide synonyms anymore.

...
[printers]
        comment = All Printers
        path = /var/spool/samba
        create mask = 0700
        printable = Yes
        print ok = Yes
        browseable = No
...

"print ok" is a synonym of "printable".

The logic used to be based on the order in the parm_table array
and same offsets.

Now we have FLAG_SYNONYM.
Comment 1 Stefan Metzmacher 2015-09-21 18:13:36 UTC 
Created attachment 11453 [details]
Patch for v4-3-test
Comment 2 Karolin Seeger 2015-10-05 07:12:47 UTC 
Pushed to autobuild-v4-3-test.
Comment 3 Karolin Seeger 2015-10-12 18:57:58 UTC 
(In reply to Karolin Seeger from comment #2)
Pushed to v4-3-test.
Closing out bug report.

Thanks!