The Samba-Bugzilla – Bug 11316
tevent_fd needs to be destroyed before closing the fd
Last modified: 2015-10-19 08:51:17 UTC
The problem that triggers bug #11141 is a generic one. This bug report is about fixing similar code paths, which could lead to the same problem.
Created attachment 11155 [details] Patches for v4-2-test (on top of the fixes for bug 11330)
Created attachment 11157 [details] Patches for v4-1-test
Comment on attachment 11157 [details] Patches for v4-1-test Doesn't build...
Comment on attachment 11155 [details] Patches for v4-2-test (on top of the fixes for bug 11330) Doesn't build... I'll resubmit...
Created attachment 11161 [details] Backport on top of v4-1-test, but not for v4-1-test (requires bug #11330 tevent-0.9.25)
Created attachment 11164 [details] Patches for v4-2-test (on top of the fixes for bug 11330)
Stefan, there's ack'ed patches for 4.2, there's also patches where you say they are on top of 4.1 but not for 4.1. What is supposed to go into what branch?
(In reply to Volker Lendecke from comment #7) I've added the 4.1 patches in case someone really hits a problem. I think backporting just to 4.2 would be enough for now. Karolin, please pick the 4.2 patchset after applying the one from bug #11330.
(In reply to Stefan (metze) Metzmacher from comment #8) Pushed to autobuild-v4-2-test.
(In reply to Karolin Seeger from comment #9) Pushed. Closing out bug report. Thanks!
There's one more fix https://git.samba.org/?p=metze/samba/wip.git;a=commitdiff;h=a9da824a24934d64d21bd
Created attachment 11344 [details] Patch for v4-3-test
Created attachment 11345 [details] Patch for v4-2-test
Pushed to autobuild-v4-{2,3}-test
Created attachment 11347 [details] Backport on top of v4-1-test, but not for v4-1-test (requires bug #11330 tevent-0.9.25)
Created attachment 11348 [details] Patches for v4-2-test There's one more patch needed for v4-2-test...
Pushed to autobuild-v4-2-test
Pushed to v4-3-test, v4-2-test is still pending
Pushed to v4-2-test
There's one more patch required...
Created attachment 11480 [details] Patch for ctdbd_connection_destructor in master This is for ctdbd_connection_destructor() (master + backports). For v4-2-test we may also need a similar fix also for ctdb_conn_destructor().
Comment on attachment 11480 [details] Patch for ctdbd_connection_destructor in master LGTM, Thanks metze!
Created attachment 11482 [details] Patch for ctdbd_connection_destructor in v4-3-test
Created attachment 11483 [details] Patch for ctdbd_connection_destructor in v4-2-test
Comment on attachment 11482 [details] Patch for ctdbd_connection_destructor in v4-3-test LGTM
Comment on attachment 11483 [details] Patch for ctdbd_connection_destructor in v4-2-test LGTM
Karolin, please include the "Patch for ctdbd_connection_destructor in v4-{2,3}-test" attachments for the next releases. Thanks!
(In reply to Stefan Metzmacher from comment #27) Pushed to autobuild-v4-[3|2]-test.
(In reply to Karolin Seeger from comment #28) Pushed to both branches. Closing out bug report. Thanks!