Bug 113 - Request to aggregate updates to change_id
Request to aggregate updates to change_id
Status: RESOLVED LATER
Product: Samba 3.0
Classification: Unclassified
Component: Printing
3.0.0preX
Other other
: P2 enhancement
: none
Assigned To: Gerald (Jerry) Carter
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2003-05-22 18:53 UTC by Gerald (Jerry) Carter
Modified: 2005-02-07 07:57 UTC (History)
0 users

See Also:


Attachments
proposed patch (3.75 KB, text/plain)
2003-05-22 18:53 UTC, Gerald (Jerry) Carter
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Gerald (Jerry) Carter 2003-05-22 18:53:04 UTC
From: Arcady Chernyak <Arcady.Chernyak@efi.com>
To: "Gerald (Jerry) Carter" <jerry@samba.org>
Subject: RE: [Samba] Point and Print problem 2.2.7A and 2.2.8

My changes mostly only in file srv_spoolss_nt.c function
construct_printer_info_0(). See attachment.
Additionally I remove "static" definition from function "rev_changeid()"
in file nt_printing.c and add it's prototype to file proto.h like:

unsigned int rev_changeid(void);

That's all.

Best regards
        Arcady


-----Original Message-----
From: Gerald (Jerry) Carter [mailto:jerry@samba.org]
Sent: Monday, April 14, 2003 12:56 PM
To: Arcady Chernyak
Subject: RE: [Samba] Point and Print problem 2.2.7A and 2.2.8

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On Mon, 14 Apr 2003, Arcady Chernyak wrote:

> I have made this change and it solve all my problems in this area.

Glad to hear it.

> I think that this is clear Windows design bug and my changes 
> really can fix it at least in SAMBA.
>
> I completely understand you arguments for stay more close to Windows.
>
> May be it's a good idea to put my changes in source code under any
> configuration switch. It means that user can choose one of "better
> performance" or "more close to Windows" options

I agree that it is a deign flaw in MS code.  I would consider
adding this as a boolean parameter though (that defaults to off).
Want to send me your patch.
Comment 1 Gerald (Jerry) Carter 2003-05-22 18:53:57 UTC
Created attachment 14 [details]
proposed patch
Comment 2 Gerald (Jerry) Carter 2004-10-21 12:51:37 UTC
someday maybe....
Comment 3 Gerald (Jerry) Carter 2005-02-07 07:57:28 UTC
originally reported against 3.0aph24.  Bugzilla spring cleaning.  
Removing old alpha versions.