Bug 11204 - CTDB statd-callout does not scale
Summary: CTDB statd-callout does not scale
Status: RESOLVED FIXED
Alias: None
Product: CTDB 2.5.x or older
Classification: Unclassified
Component: ctdb (show other bugs)
Version: 4.2.0
Hardware: All All
: P5 normal
Target Milestone: ---
Assignee: Karolin Seeger
QA Contact: Samba QA Contact
URL:
Keywords:
Depends on: 11202
Blocks:
  Show dependency tree / graph
 
Reported: 2015-04-08 07:58 UTC by Martin Schwenke
Modified: 2015-05-04 18:39 UTC (History)
3 users (show)

See Also:

Attachments
patches for v4-2 (37.00 KB, patch)
2015-04-09 05:14 UTC, Martin Schwenke 		amitay: review+
Details
additional patch for v4-2-test (1.33 KB, patch)
2015-04-21 22:25 UTC, Michael Adam 		obnox: review+
amitay: review+
Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Schwenke 2015-04-08 07:58:38 UTC 
CTDB statd-callout was re-written to contain more up-to-date data but the new implementation does not scale.  This fixes that.

Commits from master:

            d057ca0  ctdb-tests: Extend ctdb stub to support "ptrans", "pdelete", "catdb"
            2aeb518  ctdb-tests: Extend ctdb stub to support "ip" with and without -X
            9317d82  ctdb-tests: Support testing scripts that change directory
            7e7c24c  ctdb-tests: Extend eventscript unit test infrastructure for other scripts
            d98c7ba  ctdb-tests: Make setup of public addresses more obvious
            22602f7  ctdb-tests: Unit tests for statd-callout
            032441d  ctdb-scripts: Fix a regression in statd-callout
            500c6e1  ctdb-scripts: Change statd-callout to be more scalable
            50ddc2c  ctdb-scripts: Remove unused function nfs_statd_update()
            956e517  ctdb-scripts: Add a 'rm' stub so statd-callout tests work correctly

This relies on:

            363e3e2 ctdb-scripts: Don't use the GNU awk gensub() function

so has been marked as depending on BZ 11202.
Comment 1 Martin Schwenke 2015-04-09 05:14:21 UTC 
Created attachment 10940 [details]
patches for v4-2
Comment 2 Amitay Isaacs 2015-04-21 06:01:54 UTC 
Hi Karolin,

Another one for 4.2.2.

Thanks.
Comment 3 Karolin Seeger 2015-04-21 19:04:31 UTC 
Pushed to autobuild-v4-2-test.
Comment 4 Michael Adam 2015-04-21 22:24:55 UTC 
Hi.
The autobuild failed.
This is due to at least one patch missing from the above patchset:
7a10e077706efd3b5d2ce024084b7ed97d4cd36c
Comment 5 Michael Adam 2015-04-21 22:25:52 UTC 
Created attachment 10974 [details]
additional patch for v4-2-test

Additional patch needed.
Comment 6 Amitay Isaacs 2015-04-22 00:03:29 UTC 
Thanks Michael. I should set up local autobuild. :-)
Comment 7 Michael Adam 2015-04-22 08:21:04 UTC 
Amitay: it is already there, see ./script/autobuild.py to be called from any checkout... :)

Karolin: please pick this additional patch for v4-2-test and re-push. Thanks!
Comment 8 Karolin Seeger 2015-04-27 19:50:07 UTC 
(In reply to Michael Adam from comment #7)
Done.
Comment 9 Karolin Seeger 2015-05-04 18:39:32 UTC 
Pushed to v4-2-test.
Closing out bug report.

Thanks!