Created attachment 10854 [details] Patch for source3/locking/brlock.c I have been building 4.2.0 on Solaris 10 using the GNU C compiler. I decided to see what happens with Sun's C 5.11 SunOS_i386 compiler. It complains with the following error: "../source3/locking/brlock.c", line 2008: syntax error before or at: } cc: acomp failed for ../source3/locking/brlock.c The offending line is: *br_lck = (struct byte_range_lock) {}; The GNU C compiler thinks that this line is OK. The attached patch is an edited version of a patch from Christof Schmitt. It was edited to just fix the fatal error and not fix the many warnings.
Thanks. Exactly what I'd propose. Christof, what do you think?
Created attachment 10863 [details] cherry-picked patch from master Agreed, see attached patch.
Karolin, please pick to 4.1 and (if you don't insist on a separate patch) 4.2. Thanks - Michael
(In reply to Michael Adam from comment #3) Pushed to autobuild-v4-2-test.
(In reply to Karolin Seeger from comment #4) Patch does not apply to current v4-1-test.
Michael, please confirm, since you mentioned 4.1, but as far as i can see, this problem only exists in 4.2 and master. So this patch is only necessary for 4.2.
Oh, indeed. I was just misled by the "Product: Samba 4.1 and newer" above.. It is correct that Samba 4.1 is not affected. Michael
(In reply to Karolin Seeger from comment #4) Pushed to v4-2-test. Closing out bug report. Thanks!