I have been building 4.2.0 with the GNU C compiler but I decided to see how it works with the Sun C 5.11 compiler. The Sun compiler complains about a identifier being redeclared in libcli/auth/netlogon_creds_cli.c The declaration in netlogon_creds_cli.h is: NTSTATUS netlogon_creds_cli_context_tmp(const char *client_computer, const char *client_account, enum netr_SchannelType type, enum dcerpc_AuthLevel auth_level, uint32_t proposed_flags, uint32_t required_flags, const char *server_computer, const char *server_netbios_domain, TALLOC_CTX *mem_ctx, struct netlogon_creds_cli_context **_context); And the declaration in netlogon_creds_cli.c is: NTSTATUS netlogon_creds_cli_context_tmp(const char *client_computer, const char *client_account, enum netr_SchannelType type, uint32_t proposed_flags, uint32_t required_flags, enum dcerpc_AuthLevel auth_level, const char *server_computer, const char *server_netbios_domain, TALLOC_CTX *mem_ctx, struct netlogon_creds_cli_context **_context) So they are different. It is strange that the GNU C compiler does not complain.
Created attachment 10830 [details] Patch to make the .h file match the .c file I think that it does not matter which way this is defined, but both definitions have to match. Attached is a patch to make the .h file match the .c file. I expect that the GNU C compiler has been using the definition in the .c file, so this patch would not change anything in the case that the GNU compiler is used.
Created attachment 10896 [details] Patch for 4.2 Cherry-picked and reviewed patch for 4.2. The problem seems to only exist in 4.2, so no backport to 4.1 is required.
Comment on attachment 10896 [details] Patch for 4.2 ACK
Karo, please push to 4.2.next Thanks - Michael
Pushed to autobuild-v4-2-test.
(In reply to Karolin Seeger from comment #5) Pushed to v4-2-test. Closing out bug report. Thanks!