Bug 11112 - Samba master sends wrong maximum dialect 3.1 vs. 3.11
Summary: Samba master sends wrong maximum dialect 3.1 vs. 3.11
Status: RESOLVED FIXED
Alias: None
Product: Samba 4.1 and newer
Classification: Unclassified
Component: File services (show other bugs)
Version: unspecified
Hardware: All All
: P5 normal (vote)
Target Milestone: ---
Assignee: Samba QA Contact
QA Contact: Samba QA Contact
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-02-22 06:53 UTC by Steve French
Modified: 2016-12-15 02:37 UTC (History)
2 users (show)

See Also:

Attachments
wireshark trace of smbclient from samba master failing to get most current dialect connecting to Windows 10 server (16.07 KB, application/x-pcapng)
2015-02-22 06:56 UTC, Steve French 		no flags Details
wireshark trace of modified smbclient (using 0311 instead of 0310 dialect) works (6.83 KB, application/x-pcapng)
2015-02-22 06:59 UTC, Steve French 		no flags Details
patch against master to fix incorrect dialect (3.69 KB, patch)
2015-02-22 07:02 UTC, Steve French 		no flags Details
updated patch to fix obsolete dialect (9.08 KB, patch)
2015-03-12 06:01 UTC, Steve French 		sfrench: review? (ira)
 Details
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Steve French 2015-02-22 06:53:15 UTC 
Microsoft changed the dialect for Windows 10 from 0x0310 to 0x0311 see frames 45 (with current smbclient in master trying dialect 0x0310) and Windows falling back to 0x0302 in frame 48 in the response (see attached trace).
Comment 1 Steve French 2015-02-22 06:56:45 UTC 
Created attachment 10763 [details]
wireshark trace of smbclient from samba master failing to get most current dialect connecting to Windows 10 server
Comment 2 Steve French 2015-02-22 06:59:14 UTC 
Created attachment 10764 [details]
wireshark trace of modified smbclient (using 0311 instead of 0310 dialect) works
Comment 3 Steve French 2015-02-22 07:02:52 UTC 
Created attachment 10765 [details]
patch against master to fix incorrect dialect
Comment 4 Steve French 2015-03-12 06:01:12 UTC 
Created attachment 10864 [details]
updated patch to fix obsolete dialect

Found additional places where a string of the form *3_10* was used to refer to the dialect so changed these to avoid confusion (to 3_11 to match the new dialect)