Bug 11110 - uid_to_sid()/gid_to_sid() always asks winbind for the answer if the uid/gid cannot be converted.
Summary: uid_to_sid()/gid_to_sid() always asks winbind for the answer if the uid/gid c...
Status: RESOLVED FIXED
Alias: None
Product: Samba 4.1 and newer
Classification: Unclassified
Component: Other (show other bugs)
Version: unspecified
Hardware: All All
: P5 normal (vote)
Target Milestone: ---
Assignee: Andrew Bartlett
QA Contact: Samba QA Contact
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-02-20 20:10 UTC by YOUZHONG YANG
Modified: 2022-09-07 00:36 UTC (History)
0 users

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description YOUZHONG YANG 2015-02-20 20:10:12 UTC 
I confirmed that the following two line changes fixes the issue.

--- a/source3/lib/idmap_cache.c
+++ b/source3/lib/idmap_cache.c
@@ -216,6 +216,8 @@ static void idmap_cache_xid2sid_parser(time_t timeout, DATA_BLOB blob,
        if (value[0] != '-') {
                state->ret = string_to_sid(state->sid, value);
        }
+       else
+               state->ret = true;
        if (state->ret) {
                *state->expired = (timeout <= time(NULL));
        }
Comment 1 Jennifer Sutton 2022-09-07 00:36:46 UTC 
Appears to have been fixed in Samba 4.11 with d9303e8eb90d48f09f2e2e8bdf01f4a7c3c21d11.