Created attachment 10742 [details] stat open with oplock type Latest master will crash when leases are enabled whenever a Win 8.1 client does a right mouse click on a file and then chooses "Properties". smbd explodes at file_find_dif: file wanbonjour_1.pdf file_id = fd01:87df5:0, gen = 194592634 oplock_type = 256 is a stat open with oplock type ! Attached is a level 10 log of a reproducer, beginning with the right click on the file.
Blocker for 4.2.0 I think.
Ralph, can you post a wireshark trace of a Win 8.1 client doing the same against a Win8.1 server please ? I want to check what Windows does in this case.
(In reply to Jeremy Allison from comment #2) I don't have a Win8.1 server at hand atm, is a Win2012R2 ok? Btw, you should be able to reproduce this easily.
Win2k12r2 should be fine. Also, I could reproduce this easily if I wasn't out at a conference with a laptop with only one Win7 VM available :-).
OK, I have a new stat open torture tester that shows existing stat opens with leases matter when breaking. Should have a fix + new torture test shortly.
So it looks like it's only the paranoia check that needs fixing.
OK, I have reproduced the crash using my torture test, and have a fix that allows smbd to respond in the same way as Win7 (SMB2.1) server. Will do a little more testing and then post for Ralph to test.
Created attachment 10743 [details] git-am fix for master and 4.2.0 This fixes it for me and also adds a regression test (smb2.lease.statopen).
Comment on attachment 10743 [details] git-am fix for master and 4.2.0 Ralph, can you confirm this fixes the problem for you and I'll submit it for master if you're happy. Thanks, Jeremy.
(In reply to Jeremy Allison from comment #9) Fixes it for me too. Thanks!
Created attachment 10754 [details] git-am fix for 4.2.0 Contains cherry-pick information - this is the fix that went into master that was positively reviewed by Ralph.
Re-assinging to Karolin for inclusion in 4.2.0.
Pushed to autobuild-v4-2-test.
Pushed to v4-2-test. Closing out bug report. Thanks!